2133 tribe discoverability

[jtimpe]

Summary of Changes

Pull request closes #2133

How to Test

cd tdrs-backend && docker-compose up
cd tdrs-frontend && docker-compose up --build

1. Open http://localhost:3000/ and sign in. Make sure your user is in the Initial access request state and has no location or roles assigned.
2. Navigate to /home and fill out the request access form
3. Select a jurisdiction type, inspect how the stt selection box updates based on the selected type.
   • Note, if you have selected a jurisdiction type, selected an stt for that jurisdiction, and then change your jurisdiction type, the select-box does not clear out. You have to click into the select-box, then click out to clear the selection. This is a bug in uswds. The logic to clear the selection on jurisdiction type change has been added, so we should see it work immediately upon upgrade if this is fixed in an later version of uswds.
4. Complete access request

Deliverables

Checklist of ACs:

• [x] Autocomplete is NOT be enabled on the STT combobox field
• [x] STT combobox appears after jurisdiction type radio button selection
• [x] STT combobox is dynamically labeled based on radio selection
• [x] Combobox options are limited to the scope of the radio selection
• [x] Form errors reflect the number of visible errors (e.g. error count should not read 3 and not 4 if a user attempts to submit the form without choosing a jurisdiction type
• [x] Keyboard navigable. Test via activating a screenreader and navigating the form with keyboard only. The below should be default behavior but it's worth explicitly testing on a dynamic form.
  • [x] The STT combobox shouldn't be tabbable before it's visible
  • [x] Once a radio selection is made and the combobox appears it should be the next tab stop after the radio select.
• [x] lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

• Are all areas of code introduced in this PR meaningfully tested?
  • [ ] If this PR introduces backend code changes, are they meaningfully tested?
  • [x] If this PR introduces frontend code changes, are they meaningfully tested?
• Are code coverage minimums met?
  • [x] Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
  • [x] Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

• [x] Are backend code style checks passing on CircleCI?
• [x] Are frontend code style checks passing on CircleCI?
• [x] Are code maintainability principles being followed?

Deliverable 4: Accessible

• [x] Does this PR complete the epic?
• [ ] Are links included to any other gov-approved PRs associated with epic?
• [x] Does PR include documentation for Raft's a11y review?
• [x] Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

• [x] Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

• [x] Does this PR provide background for why coding decisions were made?
• [ ] If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
• [ ] If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
• [ ] If this PR introduces dependencies, are their licenses documented?
• [x] Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

• [x] Does the OWASP Scan pass on CircleCI?
• [ ] Do manual code review and manual testing detect any new security issues?
• [ ] If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

• [ ] the purpose of the research
• [ ] methods used to conduct the research
• [ ] who participated in the research
• [ ] what was tested and how
• [ ] impact of research on TDP
• [ ] (if applicable) final design mockups produced for TDP development

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.10%. Comparing base (00ac3d1) to head (14ca954). Report is 4 commits behind head on develop.

Additional details and impacted files

[](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2999?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ```diff @@ Coverage Diff @@ ## develop #2999 +/- ## =========================================== + Coverage 93.05% 93.10% +0.05% =========================================== Files 276 275 -1 Lines 7108 7047 -61 Branches 599 601 +2 =========================================== - Hits 6614 6561 -53 + Misses 399 392 -7 + Partials 95 94 -1 ``` | [Flag](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2999/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [dev-backend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `93.18% <ø> (+0.06%)` | :arrow_up: | | [dev-frontend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `92.60% <92.30%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2999?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [tdrs-frontend/src/components/ComboBox/ComboBox.jsx](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2999?src=pr&el=tree&filepath=tdrs-frontend%2Fsrc%2Fcomponents%2FComboBox%2FComboBox.jsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9Db21ib0JveC9Db21ib0JveC5qc3g=) | `100.00% <100.00%> (ø)` | | | [...rontend/src/components/STTComboBox/STTComboBox.jsx](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2999?src=pr&el=tree&filepath=tdrs-frontend%2Fsrc%2Fcomponents%2FSTTComboBox%2FSTTComboBox.jsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9TVFRDb21ib0JveC9TVFRDb21ib0JveC5qc3g=) | `90.90% <100.00%> (+0.90%)` | :arrow_up: | | [tdrs-frontend/src/components/Home/Home.jsx](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2999?src=pr&el=tree&filepath=tdrs-frontend%2Fsrc%2Fcomponents%2FHome%2FHome.jsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9Ib21lL0hvbWUuanN4) | `98.21% <87.50%> (-1.79%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2999/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2999?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2999?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Last update [d100935...14ca954](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2999?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech).

[ttran-hub]

Looking good on the auto-scans and on manual screen reader testing. 🚀

The radio buttons that help split and compress the STT drop-down list are a great addition. Thanks Team! a11y lgtm!🚀

[ADPennington]

@reitermb @ttran-hub do you all have time to add this change to the PR with the release notes? Please note the caveat @jtimpe mentions in the summary.

This PR will be approved today.

[reitermb]

@reitermb @ttran-hub do you all have time to add this change to the PR with the release notes? Please note the caveat @jtimpe mentions in the summary.

This PR will be approved today.

Is this what you had in mind? Threw together a quick draft

Improved the usability of TDP's request access form

First-time users to TDP provide their first name, last name, and associated state, tribe, or territory to help OFA administrators confirm that they should be granted access to the system. We've enhanced the form by separating the selection of whether you work at a state, tribe, or territory from the selection of the name of that jurisdiction to eliminate confusion about whether tribes need to select the name of their tribal program or the name of the state it's located in.

[reitermb]

@ADPennington Also noting that we'll throw an updated screenshot / content onto the request access steps of our getting started in TDP guides.

[ADPennington]

@reitermb @ttran-hub do you all have time to add this change to the PR with the release notes? Please note the caveat @jtimpe mentions in the summary. This PR will be approved today.

Is this what you had in mind? Threw together a quick draft

Improved the usability of TDP's request access form

First-time users to TDP provide their first name, last name, and associated state, tribe, or territory to help TDP administrators confirm access to the system. We've made revisions to the form by adding the jurisdiction type (state, tribe, or territory). After selecting the jurisdiction type, the user can more quickly locate and select the appropriate jurisdiction from the dropdown menu. the eliminate confusion about whether tribes need to select the name of their tribal program or the name of the state it's located in.

@reitermb made some minor revisions above. recommend taking this conversation to the relevant KC ticket or PR. thank you!

[ADPennington]

@jtimpe i ran into a migration issue on this PR.

[jtimpe]

@jtimpe i ran into a migration issue on this PR.

@ADPennington it was failing to connect to the db for some reason - could have been a broken ssh tunnel or maintenance issue, i'm not sure. but i re-ran and it made it past the migration step.