raft-tech / TANF-app

Repo for development of a new TANF Data Reporting System
Other
16 stars 3 forks source link

Missing HREF #3006

Closed elipe17 closed 1 month ago

elipe17 commented 1 month ago

Summary of Changes

Provide a brief summary of changes Pull request closes #2697

How to Test

List the steps to test the PR These steps are generic, please adjust as necessary.

cd tdrs-frontend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d
cd tdrs-backend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d 
  1. Open http://localhost:3000/ and sign in.
  2. Proceed with functional tests as described herein.
  3. Test steps should be captured in the demo GIF(s) and/or screenshots below.

    Demo GIF(s) and screenshots for testing procedure

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

Deliverable 2: Tested Code

Deliverable 3: Properly Styled Code

Deliverable 4: Accessible

Deliverable 5: Deployed

Deliverable 6: Documented

Deliverable 7: Secure

Deliverable 8: User Research

Research product(s) clearly articulate(s):

elipe17 commented 1 month ago

Closing after async discussion with @reitermb. Confirmed that href is included in the generated html for the email. Verified href is present locally via the console, via gmail, and via outlook. All links routed to the correct page in TDP. The only oddity was that SendGrid seems to be obscuring the true URL, see below.

<p><a class=3D"button" href=3D"https://u35556689.ct.sendgrid.net/ls/cli=
ck?upn=3Du001.iSvXeDALry182rNz3Ht0ziv0HPxvdRMIqulGqr6B1az3f78GemIfL0Xzojzt9=
Y7PMD8-_28iqB4CdAs82QkjG1SNQTqbFGuBIh1tsNbaOUFsZXQTLacOVoDzv1YeMBqYs-2B0MRh=
XYzytl4CGuDG9Lrg5tl-2Fvm9Skf-2Be6dbz8ji5pp7PcpJx23IiB6sSD7giY228nt38sy3H1Yl=
hy7yFvAr3s1NR-2FLd6TMcuHhVXwTp5LnzQI-2FZiBA-2BEzYzbKfp7unzAoNnIPy701eW8VVNz=
jxsKwNXRg-3D-3D"
    style=3D"background-color:#336a90;border-radius:4px;color:#ffffff;displ=
ay:inline-block;font-family:sans-serif;font-size:18px;font-weight:bold;line=
-height:60px;text-align:center;text-decoration:none;width: auto; padding-le=
ft: 24px; padding-right: 24px;-webkit-text-size-adjust:none;">Sign in to ke=
ep your account active</a></p>