raft-tech / TANF-app

Repo for development of a new TANF Data Reporting System
Other
16 stars 3 forks source link

Dynamic Cat4 Error Messages #3051

Open elipe17 opened 5 days ago

elipe17 commented 5 days ago

Summary of Changes

How to Test

cd tdrs-frontend && docker-compose up --build
cd tdrs-backend && docker-compose up --build
  1. Open http://localhost:3000/ and sign in.
  2. Submit some datafiles with cat4 errors
  3. Verify new error message format
  4. Verify all cat4 errors are associated with a line number

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

Deliverable 2: Tested Code

Deliverable 3: Properly Styled Code

Deliverable 4: Accessible

Deliverable 5: Deployed

Deliverable 6: Documented

Deliverable 7: Secure

Deliverable 8: User Research

Research product(s) clearly articulate(s):

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 90.76923% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.99%. Comparing base (fb0e539) to head (8ded7af).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051/graphs/tree.svg?width=650&height=150&src=pr&token=BA04YXPAL9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech)](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ```diff @@ Coverage Diff @@ ## fix/cat3-error-cleanup #3051 +/- ## ======================================================= Coverage 92.99% 92.99% ======================================================= Files 276 276 Lines 7338 7369 +31 Branches 649 654 +5 ======================================================= + Hits 6824 6853 +29 - Misses 413 414 +1 - Partials 101 102 +1 ``` | [Flag](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [dev-backend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `93.05% <90.76%> (+<0.01%)` | :arrow_up: | | [dev-frontend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `92.60% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [...d/tdpservice/parsers/schema\_defs/tribal\_tanf/t1.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Ftribal_tanf%2Ft1.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy90cmliYWxfdGFuZi90MS5weQ==) | `100.00% <ø> (ø)` | | | [...d/tdpservice/parsers/schema\_defs/tribal\_tanf/t2.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Ftribal_tanf%2Ft2.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy90cmliYWxfdGFuZi90Mi5weQ==) | `100.00% <ø> (ø)` | | | [...d/tdpservice/parsers/schema\_defs/tribal\_tanf/t3.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Ftribal_tanf%2Ft3.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy90cmliYWxfdGFuZi90My5weQ==) | `90.90% <ø> (ø)` | | | [...d/tdpservice/parsers/schema\_defs/tribal\_tanf/t5.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Ftribal_tanf%2Ft5.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy90cmliYWxfdGFuZi90NS5weQ==) | `100.00% <ø> (ø)` | | | [tdrs-backend/tdpservice/parsers/validators.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fvalidators.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy92YWxpZGF0b3JzLnB5) | `92.19% <100.00%> (+0.02%)` | :arrow_up: | | [...d/tdpservice/parsers/case\_consistency\_validator.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fcase_consistency_validator.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9jYXNlX2NvbnNpc3RlbmN5X3ZhbGlkYXRvci5weQ==) | `96.91% <94.64%> (-0.49%)` | :arrow_down: | | [tdrs-backend/tdpservice/parsers/parse.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fparse.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9wYXJzZS5weQ==) | `86.15% <57.14%> (+0.04%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Last update [fb0e539...8ded7af](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3051?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech).