raft-tech / TANF-app

Repo for development of a new TANF Data Reporting System
Other
17 stars 4 forks source link

3043 Sentry local #3101

Closed raftmsohani closed 2 months ago

raftmsohani commented 4 months ago

Summary of Changes

Added containerized Sentry to local dev environment

Pull request closes #3043

How to Test

You can bring up Sentry using task file:

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

Deliverable 2: Tested Code

Deliverable 3: Properly Styled Code

Deliverable 4: Accessible

Deliverable 5: Deployed

Deliverable 6: Documented

Deliverable 7: Secure

Deliverable 8: User Research

Research product(s) clearly articulate(s):

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.42%. Comparing base (398511c) to head (05228b0). Report is 1 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3101/graphs/tree.svg?width=650&height=150&src=pr&token=BA04YXPAL9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech)](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ```diff @@ Coverage Diff @@ ## develop #3101 +/- ## ======================================== Coverage 91.42% 91.42% ======================================== Files 288 288 Lines 7980 7980 Branches 746 746 ======================================== Hits 7296 7296 Misses 578 578 Partials 106 106 ``` | [Flag](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3101/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [dev-backend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3101/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `91.25% <ø> (ø)` | | | [dev-frontend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3101/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `92.60% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#carryforward-flags-in-the-pull-request-comment) to find out more. ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3101?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3101?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Last update [398511c...05228b0](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3101?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech).
raftmsohani commented 3 months ago

According to Sentry repo, Sentry cannot run on ARM cpus (see this)

Have tested local sentry in two different ways:

  1. Run Sentry in docker-in-docker. It runs at 7.8G

Screenshot 2024-08-05 at 4 40 08 PM

  1. Run Sentry in Ubuntu linux with a running docker engine

Screenshot 2024-08-05 at 4 34 34 PM

raftmsohani commented 3 months ago

I think (despite Sentry's MD) that this install still needs 14-16GB of memory. I was able to run the task with 8GB but Kafka restarts over and over. I can still access the Sentry frontend but I worry about losing state/info if Kafka is restarting every minute or so. When I let Sentry have 32GB of memory, it seems happy at about 12GB. All containers start and stay alive at that point. Screenshot 2024-08-06 at 8 06 06 AM

@elipe17 what version of docker and docker-desktop are you running?

elipe17 commented 3 months ago

I think (despite Sentry's MD) that this install still needs 14-16GB of memory. I was able to run the task with 8GB but Kafka restarts over and over. I can still access the Sentry frontend but I worry about losing state/info if Kafka is restarting every minute or so. When I let Sentry have 32GB of memory, it seems happy at about 12GB. All containers start and stay alive at that point. Screenshot 2024-08-06 at 8 06 06 AM

@elipe17 what version of docker and docker-desktop are you running? @raftmsohani Screenshot 2024-08-06 at 8 54 57 AM

raftmsohani commented 3 months ago

I think (despite Sentry's MD) that this install still needs 14-16GB of memory. I was able to run the task with 8GB but Kafka restarts over and over. I can still access the Sentry frontend but I worry about losing state/info if Kafka is restarting every minute or so. When I let Sentry have 32GB of memory, it seems happy at about 12GB. All containers start and stay alive at that point. Screenshot 2024-08-06 at 8 06 06 AM

@elipe17 what version of docker and docker-desktop are you running? @raftmsohani Screenshot 2024-08-06 at 8 54 57 AM

Screenshot 2024-08-08 at 3 59 20 PM

Updating to newer version might free up some memory

elipe17 commented 3 months ago

I think (despite Sentry's MD) that this install still needs 14-16GB of memory. I was able to run the task with 8GB but Kafka restarts over and over. I can still access the Sentry frontend but I worry about losing state/info if Kafka is restarting every minute or so. When I let Sentry have 32GB of memory, it seems happy at about 12GB. All containers start and stay alive at that point. Screenshot 2024-08-06 at 8 06 06 AM

@elipe17 what version of docker and docker-desktop are you running? @raftmsohani Screenshot 2024-08-06 at 8 54 57 AM

Screenshot 2024-08-08 at 3 59 20 PM

Updating to newer version might free up some memory

@raftmsohani I am still seeing Kafka restart every minute or so when we only give the container 8GB of mem. Did anything new come out of OH while I was gone regarding this PR?

raftmsohani commented 3 months ago

I think (despite Sentry's MD) that this install still needs 14-16GB of memory. I was able to run the task with 8GB but Kafka restarts over and over. I can still access the Sentry frontend but I worry about losing state/info if Kafka is restarting every minute or so. When I let Sentry have 32GB of memory, it seems happy at about 12GB. All containers start and stay alive at that point. Screenshot 2024-08-06 at 8 06 06 AM

@elipe17 what version of docker and docker-desktop are you running? @raftmsohani Screenshot 2024-08-06 at 8 54 57 AM

Screenshot 2024-08-08 at 3 59 20 PM Updating to newer version might free up some memory

@raftmsohani I am still seeing Kafka restart every minute or so when we only give the container 8GB of mem. Did anything new come out of OH while I was gone regarding this PR?

@elipe17 You will need to assign 10G for docker-in-docker. I checked this on a bare linux machine and 8G was totally fine

raftmsohani commented 3 months ago

WAITING to pair during office hrs with dev team and @ADPennington

ADPennington commented 3 months ago

Approved with the understanding that this will not be the package deployed to cloud.gov and that configuration of this tool requires at least 12GB RAM to connect/configure with a side-by-side version of our app and it limited in it's functionality at this time. @ADPennington Given the hurdle here and that this will not be going to cloud.gov but will be exclusively for the local developer experience, I think we should bypass QASP.

@lfrohlich I've agreed that dev can merge this without qasp review. team will introduce a ticket for an ADR about sentry. This will be presented internally and will also be good to share/present to cloudgov team so there's a shared understanding of what we need and why.