Closed raftmsohani closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.42%. Comparing base (
398511c
) to head (05228b0
). Report is 1 commits behind head on develop.
According to Sentry repo, Sentry cannot run on ARM cpus (see this)
Have tested local sentry in two different ways:
I think (despite Sentry's MD) that this install still needs 14-16GB of memory. I was able to run the
task
with 8GB but Kafka restarts over and over. I can still access the Sentry frontend but I worry about losing state/info if Kafka is restarting every minute or so. When I let Sentry have 32GB of memory, it seems happy at about 12GB. All containers start and stay alive at that point.
@elipe17 what version of docker and docker-desktop are you running?
I think (despite Sentry's MD) that this install still needs 14-16GB of memory. I was able to run the
task
with 8GB but Kafka restarts over and over. I can still access the Sentry frontend but I worry about losing state/info if Kafka is restarting every minute or so. When I let Sentry have 32GB of memory, it seems happy at about 12GB. All containers start and stay alive at that point.@elipe17 what version of docker and docker-desktop are you running? @raftmsohani
I think (despite Sentry's MD) that this install still needs 14-16GB of memory. I was able to run the
task
with 8GB but Kafka restarts over and over. I can still access the Sentry frontend but I worry about losing state/info if Kafka is restarting every minute or so. When I let Sentry have 32GB of memory, it seems happy at about 12GB. All containers start and stay alive at that point.@elipe17 what version of docker and docker-desktop are you running? @raftmsohani
Updating to newer version might free up some memory
I think (despite Sentry's MD) that this install still needs 14-16GB of memory. I was able to run the
task
with 8GB but Kafka restarts over and over. I can still access the Sentry frontend but I worry about losing state/info if Kafka is restarting every minute or so. When I let Sentry have 32GB of memory, it seems happy at about 12GB. All containers start and stay alive at that point.@elipe17 what version of docker and docker-desktop are you running? @raftmsohani
Updating to newer version might free up some memory
@raftmsohani I am still seeing Kafka restart every minute or so when we only give the container 8GB of mem. Did anything new come out of OH while I was gone regarding this PR?
I think (despite Sentry's MD) that this install still needs 14-16GB of memory. I was able to run the
task
with 8GB but Kafka restarts over and over. I can still access the Sentry frontend but I worry about losing state/info if Kafka is restarting every minute or so. When I let Sentry have 32GB of memory, it seems happy at about 12GB. All containers start and stay alive at that point.@elipe17 what version of docker and docker-desktop are you running? @raftmsohani
Updating to newer version might free up some memory
@raftmsohani I am still seeing Kafka restart every minute or so when we only give the container 8GB of mem. Did anything new come out of OH while I was gone regarding this PR?
@elipe17 You will need to assign 10G for docker-in-docker. I checked this on a bare linux machine and 8G was totally fine
WAITING to pair during office hrs with dev team and @ADPennington
Approved with the understanding that this will not be the package deployed to cloud.gov and that configuration of this tool requires at least 12GB RAM to connect/configure with a side-by-side version of our app and it limited in it's functionality at this time. @ADPennington Given the hurdle here and that this will not be going to cloud.gov but will be exclusively for the local developer experience, I think we should bypass QASP.
@lfrohlich I've agreed that dev can merge this without qasp review. team will introduce a ticket for an ADR about sentry. This will be presented internally and will also be good to share/present to cloudgov team so there's a shared understanding of what we need and why.
Summary of Changes
Added containerized Sentry to local dev environment
Pull request closes #3043
How to Test
You can bring up Sentry using task file:
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):