raft-tech / TANF-app

Repo for development of a new TANF Data Reporting System
Other
17 stars 4 forks source link

3224 Audit Logger #3250

Open raftmsohani opened 3 weeks ago

raftmsohani commented 3 weeks ago

Summary of Changes

Provide a brief summary of changes Pull request closes #3224

See attached excel file

log_messages.xlsx

How to Test

Go through the excel file above and see all the logs

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

Deliverable 2: Tested Code

Deliverable 3: Properly Styled Code

Deliverable 4: Accessible

Deliverable 5: Deployed

Deliverable 6: Documented

Deliverable 7: Secure

Deliverable 8: User Research

Research product(s) clearly articulate(s):

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.46%. Comparing base (8d01df3) to head (5c612f6). Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
tdrs-backend/tdpservice/parsers/fields.py 50.00% 3 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3250/graphs/tree.svg?width=650&height=150&src=pr&token=BA04YXPAL9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech)](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ```diff @@ Coverage Diff @@ ## develop #3250 +/- ## =========================================== - Coverage 91.48% 91.46% -0.03% =========================================== Files 297 297 Lines 8433 8436 +3 Branches 611 611 =========================================== + Hits 7715 7716 +1 - Misses 605 607 +2 Partials 113 113 ``` | [Flag](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3250/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [dev-backend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `91.32% <66.66%> (-0.03%)` | :arrow_down: | | [dev-frontend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `92.51% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3250?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [tdrs-backend/tdpservice/parsers/util.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3250?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Futil.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy91dGlsLnB5) | `93.91% <100.00%> (ø)` | | | [...backend/tdpservice/parsers/validators/category3.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3250?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fvalidators%2Fcategory3.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy92YWxpZGF0b3JzL2NhdGVnb3J5My5weQ==) | `97.70% <100.00%> (-0.02%)` | :arrow_down: | | [tdrs-backend/tdpservice/parsers/fields.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3250?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Ffields.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9maWVsZHMucHk=) | `77.55% <50.00%> (-2.45%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3250?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3250?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Last update [c230985...5c612f6](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3250?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech).

🚨 Try these New Features:

andrew-jameson commented 3 weeks ago

Thank you for the attached spreadsheet, good work!

image

The bottom 3 red lines here expose case number however I'm not sure case number qualifies as PII so no action needed here? Indeed, wouldn't providing the case number be helpful for analysts to resolve issues?