Open raftmsohani opened 3 weeks ago
Attention: Patch coverage is 66.66667%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 91.46%. Comparing base (
8d01df3
) to head (5c612f6
). Report is 2 commits behind head on develop.
Files with missing lines | Patch % | Lines |
---|---|---|
tdrs-backend/tdpservice/parsers/fields.py | 50.00% | 3 Missing :warning: |
🚨 Try these New Features:
Thank you for the attached spreadsheet, good work!
The bottom 3 red lines here expose case number however I'm not sure case number qualifies as PII so no action needed here? Indeed, wouldn't providing the case number be helpful for analysts to resolve issues?
Summary of Changes
Provide a brief summary of changes Pull request closes #3224
See attached excel file
log_messages.xlsx
How to Test
Go through the excel file above and see all the logs
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):