raftario / filite

A simple, light and standalone pastebin, URL shortener and file-sharing service
MIT License
190 stars 16 forks source link

Allow the user to disable the use of the cdnjs #17

Open eyedeekay opened 4 years ago

eyedeekay commented 4 years ago

I wanted to host this pastebin as an I2P service and discovered there wasn't a way to disable the use of the CDN as the source of the CSS and Javascript. I wanted to at least be able to use the defaults without the CDN, so today(at last) I wrote my first ~95 lines of Rust. I added a new variable(themepath) which can either point to a CDN source or be left blank to use the default theme without needing another service. Looking forward to your feedback.

raftario commented 4 years ago

Thanks for the PR, that's definitely a nice feature to have. I see a bit of duplicate code that could be merged into functions but apart from that it looks good. I'm a bit busy right now, will review it as soon as I have more time, probably some time in the next week.

raftario commented 4 years ago

Hey, sorry for not following up with that but this whole situation has been quite something and made me forget about this PR. I plan to rewrite filite completely in the next few days and get rid of the CDN altogether. I'll keep this open until the rewrite is done, but I'll probably close it afterwards.

eyedeekay commented 4 years ago

Thanks for getting back to me, glad to hear that the feature I wanted will be available in any case. Looking forward to updating.