search

ragardner / tksheet

Python tkinter table widget for displaying tabular data
https://pypi.org/project/tksheet/
MIT License
408 stars 50 forks source link

conda-forge channel support #198

Open WWGolay opened 1 year ago

WWGolay commented 1 year ago

Hello,

I'm developing a package that tksheet is a dependency of. I want to put it on conda-forge, but that means all my package's dependencies must also be on conda-forge. This PR has the meta.yaml file needed. Here is the guide for adding to conda-forge: https://conda-forge.org/docs/maintainer/adding_pkgs.html.

WWGolay commented 1 year ago

I got the sha256 change done. I also added tk as a requirement. I added a few other fields that previously have been requested when adding packages to conda-forge. Also, I'm happy to do the steps from that link to get tksheet on conda-forge if you'd prefer.

ragardner commented 1 year ago

Thanks a lot,

I am sorry to mess you around a bit but,

I remembered sorry that the reason the hashes might be different is the zipped files are different on pypi here: https://pypi.org/project/tksheet/#files

compared to github here: https://github.com/ragardner/tksheet/archive/6.2.3.tar.gz

I think when you use the command pip install tksheet it uses the pypi link e.g. https://files.pythonhosted.org/packages/02/d7/2bd895e2558f31b66e53346898e42476cc562a74f69b73d1aeb377769b6f/tksheet-6.2.3.tar.gz

because it would have the files generated by python setup.py sdist necessary for pip to install a package e.g. https://docs.python.org/3/distutils/sourcedist.html

I'm not sure which link would be appropriate to use

I have given a bit of thought to who should add it to conda-forge,

I think given your requirement it might be better if you forked tksheet and did it, I might not be around to support it on conda if you need it modified

I am open to suggestions though

WWGolay commented 1 year ago

No problem. The SHA256 question is also unclear to me... I did try to run conda build . in the root of my local fork of the repo, and it was successfully built, so I suppose it's the correct key.

Yes, I'm happy to take care of getting it on conda-forge—no worries on that front. I'm also doing this for another package that I need support for.

ragardner commented 1 year ago

Yes, I'm happy to take care of getting it on conda-forge—no worries on that front. I'm also doing this for another package that I need support for.

Sorry for the long delay but if you haven't already, yes you can go ahead and put it on conda forge if you want