search

ragavvenkatesan / yann

This toolbox is support material for the book on CNN (http://www.convolution.network).
http://www.yann.network
Other
41 stars 27 forks source link

CelebA dataset support added #74

Closed anchitagarwal closed 7 years ago

ragavvenkatesan commented 7 years ago

Can you check the last commit again ? There is something wrong. It fails the test. The commit before that is working properly.

anchitagarwal commented 7 years ago

Nope. Just added my code. I double checked using diffmerge. I pulled the dev branch. Is it possible I checked out the wrong branch?

On Thu, Jun 1, 2017, 9:15 AM Ragav Venkatesan notifications@github.com wrote:

@ragavvenkatesan commented on this pull request.

In yann/utils/dataset.py https://github.com/ragavvenkatesan/yann/pull/74#discussion_r119660404:

@@ -1480,7 +1480,7 @@ def _create_skdata_caltech256(self, verbose = 2): #pragma: no cover if verbose >=2: print(".. Validation data") looper = n_valid_images / ( self.mini_batches_per_batch[2] * self.mini_batch_size )

  • for i in xrange(looper): # for each batch_i file....

Why have you done these?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ragavvenkatesan/yann/pull/74#pullrequestreview-41560944, or mute the thread https://github.com/notifications/unsubscribe-auth/AGwgYyoDdxu9oxdvbCYovu9M25XRVUDGks5r_uOvgaJpZM4Nso_T .

ragavvenkatesan commented 7 years ago

Can you make this PR into V1 branch ?