rage / mooc.fi

https://mooc.fi
5 stars 6 forks source link

Refactor: remove redundant coursetag table #1116

Closed mipyykko closed 1 year ago

mipyykko commented 1 year ago

Realized the CourseTag was completely unnecessary and Prisma will do the same thing for me. Basically renames the table and its columns and removes boilerplate.

Also fixes the broken beta editor, now (course) tag editing works.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1116 (09b8d19) into master (4d9c6bf) will increase coverage by 0.41%. The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
+ Coverage   67.39%   67.81%   +0.41%     
==========================================
  Files         118      117       -1     
  Lines        4748     4663      -85     
  Branches     1020      999      -21     
==========================================
- Hits         3200     3162      -38     
+ Misses       1431     1391      -40     
+ Partials      117      110       -7     
Flag Coverage Δ
backend 67.78% <95.45%> (+0.41%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/graphql/Course/__test__/util.ts 100.00% <ø> (ø)
backend/graphql/index.ts 100.00% <ø> (ø)
backend/tests/data/fixtures.ts 100.00% <ø> (ø)
backend/graphql/Course/queries.ts 94.36% <66.66%> (-0.23%) :arrow_down:
backend/graphql/Course/input.ts 100.00% <100.00%> (ø)
backend/graphql/Course/model.ts 98.86% <100.00%> (ø)
backend/graphql/Course/mutations.ts 83.58% <100.00%> (-0.48%) :arrow_down:
backend/graphql/Tag.ts 48.59% <100.00%> (ø)
backend/tests/data/seed.ts 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more