rage / mooc.fi

https://mooc.fi
5 stars 6 forks source link

Set new editor as default and other fixes #1157

Closed mipyykko closed 1 year ago

mipyykko commented 1 year ago

Dozens of small changes in the editor to make it work better and faster, or mainly to work properly.

I did rename the files and directories so that git would remember the history, but seems that for example the common fields changed so much (>50%) that it now regards them as new files here. However, when doing git log --follow <filename> the actual history seems to be correct. Go figure.

The anchors live in the editor context now and that's a bit unfortunate. The path to the actual editor from the page is still a bit convoluted, but refactored somewhat.

What's problematic with the course editor now is that it's tabbed -- instead of not rendering what's on the other tabs like one probably should do, I had to just hide it with CSS so the input fields would not unmount (and remount as we travelled back) needlessly. However, this doesn't really seem to show in the functionality or performance.

Old editor(s) are available with ?legacy=true (or =1 or anything truthy)

codecov[bot] commented 1 year ago

Codecov Report

Merging #1157 (a08d719) into master (f0fbbaa) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1157   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files         122      122           
  Lines        4856     4856           
  Branches     1069     1069           
=======================================
  Hits         3249     3249           
  Misses       1492     1492           
  Partials      115      115           
Flag Coverage Δ
backend 66.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more