rage / mooc.fi

https://mooc.fi
5 stars 6 forks source link

Fix stats emailer cronjobs #1265

Closed Redande closed 2 months ago

Redande commented 2 months ago

Multiple cronjobs are generated from values.yaml. They had identical name so only the last one was created, this PR gives unique names to the cronjobs based on the id defined in values.yaml. This should allow for multiple cronjobs from the same template (with differing schedules).

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.43%. Comparing base (bb98b52) to head (f4bbf92). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1265 +/- ## ======================================= Coverage 66.43% 66.43% ======================================= Files 144 144 Lines 6042 6042 Branches 1434 1434 ======================================= Hits 4014 4014 Misses 1889 1889 Partials 139 139 ``` | [Flag](https://app.codecov.io/gh/rage/mooc.fi/pull/1265/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rage) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/rage/mooc.fi/pull/1265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rage) | `66.43% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rage#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.