rage / tmc-core-abandoned

0 stars 1 forks source link

Don't disable "run tests locally" action after deadline. #31

Open jamo opened 10 years ago

jamo commented 10 years ago

There is the question of how to clearly indicate that the deadline has passed. Options suggested:

  1. Have the popup say that. Problem: users will not read popups.
  2. Change the icon (and mouseover). Problem: users will not understand the change despite the mouseover)
  3. Change how test results are presented. Perhaps add to the test result UI, with a red bold font, "Note: deadline exceeded. You can no longer get points for this exercise."

Maybe use red eye when deadline has passed and green otherwise.

I have good versions of these pictures somewhere.

ljleppan commented 10 years ago

This seems like something better solved on the client's end.

I'd also avoid having color as the only distiguishing feature between pre- and post-deadline states for the exercise to better facialiate any users with full or partial color blindness. Red and green as colors are especially difficult.

jamo commented 10 years ago

We have had some discussion regarding the implementation https://github.com/testmycode/tmc-netbeans/issues/81

It might be nice to have core to support (and make the decision) whether each the icon should be disabled or enabled and if exercise can it be submitted.

The allowRunningTestsAfterDeadline might make it to exercise specific flag eventually...

On Mon Nov 03 2014 at 3:26:41 PM Leo Leppänen notifications@github.com wrote:

This seems like something better solved on the client's end.

I'd also avoid having color as the only distiguishing feature between pre- and post-deadline states for the exercise to better facialiate any users with full or partial color blindness. Red and green as colors are especially difficult.

— Reply to this email directly or view it on GitHub https://github.com/rage/tmc-core/issues/31#issuecomment-61484487.