search

rageagainsthepc / GuitarPro-to-Midi

Convert all GuitarPro formats (3 to 7) to Midi simulating bending, overtones etc.
65 stars 7 forks source link

Ignore unhandled data #25

Closed AdamSEY closed 11 months ago

AdamSEY commented 1 year ago

Ignore unhandled data instead of throwing an error.

AdamSEY commented 1 year ago

I had to remove the whole repository and start over with the changes, it seems like I cloned the repository in an ambiguous way.

rageagainsthepc commented 1 year ago

@AdamSEY Hi, just checking in. You still have build errors. Are you going to fix those?

AdamSEY commented 1 year ago

I don't know what actually the issue is, I just used NLog as you used in your code, can you spot any errors with the implementation?

rageagainsthepc commented 1 year ago

Please revert unrelated whitespace changes (line 13, 918). Other than that looks good to me. 👍

rageagainsthepc commented 11 months ago

@AdamSEY Are you planning on finishing this PR?

AdamSEY commented 11 months ago

@rageagainsthepc I cannot seem to find free time to do it, very sorry.