search

rageqqq / pe

0 stars 0 forks source link

Links without http/ https should not be allowed to be stored #5

Open rageqqq opened 3 years ago

rageqqq commented 3 years ago

If there is a http/ https requirement, why allow links without http/ https to be stored?

image.png

Adding http:// allows the app to open the given website.

image.png

However, removing the http:// does not allow the app to open the website

nus-pe-bot commented 3 years ago

Team's Response

We agree that this is an issue. However, we believe that it causes only minor inconvenience to the user (since the only impact is not being able to open the link), hence we reduced the severity with low.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Won't it be inconvenient if the original links do not include http/https? For example the github.io links that this module uses. This can cause an inconvenience as user would have to manually input http:// in front everytime which would make their experience less pleasant