rageqqq / pe

0 stars 0 forks source link

Inconsistent output when providing invalid commands #9

Open rageqqq opened 3 years ago

rageqqq commented 3 years ago

image.png

When inputting an invalid command with only 1 argument (i.e. "helpp"), the output is shown as invalid command. However, when an invalid command with 2 or more arguments are given (i.e. "help a b"), the output is shown as unknown command.

It might be good to have both cases show the same output, ideally the invalid command output which also tells the user to enter "help" if unsure about the commands available

nus-pe-bot commented 3 years ago

Team's Response

For the command "help aa", the keyword is correct, but the number of arguments is invalid. We assume that the user knows the keyword, hence we did not provide the help. For the command "helpp", the keyword is wrong and we assume that the user does not know what the command is. Hence, we provided the "help". Perhaps the last line infers that this is a suggestion? In that case, it does not seem to affect the functionality.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I feel it might be a little inconvenient for the user. There is no harm in providing the help.