raghakot / keras-vis

Neural network visualization toolkit for keras
https://raghakot.github.io/keras-vis
MIT License
2.98k stars 664 forks source link

guided gradcam naming issue #201

Open eyaler opened 4 years ago

eyaler commented 4 years ago

there is an example of gradcam with guided backprop modifier. but in the literature guided gradcam means something else: guided backprop multiplied by gradcam

keisen commented 4 years ago

Hi, @eyaler . Thank you for your proposal. But the name was named by the paper that proposed Grad-CAM, so we aren't going to rename.

https://arxiv.org/pdf/1610.02391.pdf

We'll close this issue, but please feel free to reopen whenever you need. Thanks!

eyaler commented 4 years ago

@keisen so in the paper:

guided grad cam = visualize_saliency(backprop_modifier='guided') * visualize_cam()

this is different from the "guided grad cam" implied in keras-vis:

visualize_cam(backprop_modifier='guided')

you can see an example here: bit.ly/vis-colab

keisen commented 4 years ago

Hi, @eyaler , Thank you for your great easy to understand example! I got it, so I reopened this in your stead.

I believe that we should add explanation how to visualize guided-gradcam to the gradcam section of the example notebook. Would you please submit a PullRequest that improve this issue?

Thanks!