Closed algodave closed 8 years ago
LGTM. I think that's a nice touch. Thanks @algodave!
@jasonkriss Thanks for merging! I would then suggest you remove line#28 from the README:
app_id: config['ember-cli-intercom'].appId,
and issue a new release. Do you agree?
Absolutely! Done.
It might be annoying to pass the
app_id
param when invoking theboot()
method. I suggest to have the addon take care of that. To do so, I had to moveservice.js
fromaddon/services
toapp/services
in order to allow it to import theconfig/environment.js
file