Automatically pass app_id param to Intercom

ragnarpeterson / ember-cli-intercom

ember addon to easily add Intercom to your app

MIT License

10 stars 15 forks source link

Automatically pass app_id param to Intercom #2

Closed algodave closed 8 years ago

algodave commented 8 years ago

It might be annoying to pass the app_id param when invoking the boot() method. I suggest to have the addon take care of that. To do so, I had to move service.js from addon/services to app/services in order to allow it to import the config/environment.js file

jasonkriss commented 8 years ago

LGTM. I think that's a nice touch. Thanks @algodave!

algodave commented 8 years ago

@jasonkriss Thanks for merging! I would then suggest you remove line#28 from the README:

app_id: config['ember-cli-intercom'].appId,

and issue a new release. Do you agree?

jasonkriss commented 8 years ago

Absolutely! Done.