Closed tomwespi closed 7 years ago
Hey Tom, I've reverted your commit. Several reasons:
That said, I've committed proper fix now and will release it as version 2.0 (for Magnolia 5.5 only). The other issue you have encountered with your solution was https://jira.magnolia-cms.com/browse/MGNLGROOVY-157 You should not see it again w/ the final fix that I've pushed in.
Hei Jan
sorry, this was a lousy commit from me, I was just to much in a hurry. Also I will learn a bit more about GIT (branch, master etc).
See you tonight and cheers
Tom
On 20 Nov 2016, at 12:00, Jan Haderka notifications@github.com wrote:
Hey Tom, I've reverted your commit. Several reasons:
• please use issue number w/ hash (#) in front of them when working on issues to get commits referenced in the issue log automatically • when not sure about solution, please commit it on a branch or on a fork, not directly on master • There was reference to your own (esence) class in the import in modified code • The changes were going in right direction, but were far from finished. That said, I've committed proper fix now and will release it as version 2.0 (for Magnolia 5.5 only). The other issue you have encountered with your solution was https://jira.magnolia-cms.com/browse/MGNLGROOVY-157 You should not see it again w/ the final fix that I've pushed in.
Viele Grüsse
esense GmbH Burgweg 7 CH-4058 Basel
+41 (0)61 271 35 01
info@esense.ch www.esense.ch
Gute Webseiten.
Since Magnolia 5.5 is depend on Groovy 2.4.6, the scripted select does not work anymore.