search

rahafoundation / raha-mobile-app

Mobile app for Raha
8 stars 1 forks source link

Bump RN Firebase version to v5.1.1. #520

Closed rahulgi closed 5 years ago

rahulgi commented 5 years ago

This results in major dependency jumps for associated firebase libraries (notably google-play-services base which goes from 15 to 16 on Android and iOS Firebase Pods which go from 5.3 to 5.11).

This commit also adds the Firestore dependency.

I successfully built and tested the app on Android. Successfully built for iOS but would appreciate if either of you, @tinaroh and @osdiab, could try installing it on your iOS device and playing around with it to make sure everything still looks good.

tinaroh commented 5 years ago

I won't have my iPad for the next two days, sorry. @osdiab can you test for him?

osdiab commented 5 years ago

Sure will do later today On Wed, Nov 28, 2018 at 01:04 Tina Roh notifications@github.com wrote:

I won't have my iPad for the next two days, sorry. @osdiab https://github.com/osdiab can you test for him?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rahafoundation/raha-mobile-app/pull/520#issuecomment-442114505, or mute the thread https://github.com/notifications/unsubscribe-auth/ABzabn1DHnZDCBqNx4fBaES_5laFl255ks5uzWKogaJpZM4Y1DMD .

osdiab commented 5 years ago

Checked, it seems to work for logging in via text, uploading verification videos.

osdiab commented 5 years ago

man, committing all these dependencies is so big lol

rahulgi commented 5 years ago

excellent. yeah it's pretty crazy lol