search

rahafoundation / raha-web-app

The Raha identity network supporting universal basic income.
https://web.raha.app
Apache License 2.0
10 stars 3 forks source link

Use shared api client #153

Closed osdiab closed 6 years ago

osdiab commented 6 years ago

It's alive! This moves the code for calling the API out of the web app, so it can be reused on native.

Holding off on merging until I can figure out the testing/transpilation of libraries story

The api client is here. https://github.com/rahafoundation/api-client . It is dependent on https://github.com/rahafoundation/raha-api/pull/44, but I already pushed the tentative code to npm so all should be fine regardless if that gets merged now.

osdiab commented 6 years ago

Not entirely sure why the tests fail to run, seems that the libraries I wrote are not being transpiled in the test context.

EDIT: looks like that's it, I tried adding a flag to the test invocation to make it transpile on those tests for our libraries but now it just explodes for a different reason. sigh... Well the tests are not high pri given that we haven't written much lol

Let’s hold off on doing this until some future point where these transpilation shortcomings are solved or I find a way to precompile it without losing flexibility.