search

rahafoundation / raha-web-app

The Raha identity network supporting universal basic income.
https://web.raha.app
Apache License 2.0
10 stars 3 forks source link

Add fallback scheme for Raha deeplinks in invite page #183

Closed tinaroh closed 6 years ago

tinaroh commented 6 years ago
screen shot 2018-09-03 at 9 04 18 am
tinaroh commented 6 years ago

it's a little too complicated to explain I think. I don't know if the custom link is fully reliable either. I can't push this until tomorrow, can someone merge and deploy for me?

On Mon, Sep 3, 2018, 2:08 PM Rahul Gupta-Iwasaki notifications@github.com wrote:

@rahulgi approved this pull request.

In src/pages/AcceptInvite.tsx https://github.com/rahafoundation/raha-web-app/pull/183#discussion_r214576603 :

  • <p style={{ fontSize: 12 }}>
  • Apple and the Apple logo are trademarks of Apple Inc., registered in
  • the U.S. and other countries and regions. App Store is a service mark
  • of Apple Inc.

  • <a style={{ fontSize: 18 }} href={httpsSchemeDeeplink}>
  • {httpsSchemeDeeplink}

    • LGTM, but could we add a comment or something saying why the first link might not work? Are https links less reliable? What if we just showed them the second link?

    — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahafoundation/raha-web-app/pull/183#pullrequestreview-151660588, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPIBTiRgzDkBXyNOtJqHS3-5E52CRhGks5uXLk9gaJpZM4WW0No .

    tinaroh commented 6 years ago

    I think we should just have both for now and then we can simplify later.

    On Mon, Sep 3, 2018, 2:10 PM Tina Roh tinaroh@gmail.com wrote:

    it's a little too complicated to explain I think. I don't know if the custom link is fully reliable either. I can't push this until tomorrow, can someone merge and deploy for me?

    On Mon, Sep 3, 2018, 2:08 PM Rahul Gupta-Iwasaki notifications@github.com wrote:

    @rahulgi approved this pull request.

    In src/pages/AcceptInvite.tsx https://github.com/rahafoundation/raha-web-app/pull/183#discussion_r214576603 :

    • <p style={{ fontSize: 12 }}>
    • Apple and the Apple logo are trademarks of Apple Inc., registered in
    • the U.S. and other countries and regions. App Store is a service mark
    • of Apple Inc.

  • <a style={{ fontSize: 18 }} href={httpsSchemeDeeplink}>
  • {httpsSchemeDeeplink}

    • LGTM, but could we add a comment or something saying why the first link might not work? Are https links less reliable? What if we just showed them the second link?

    — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahafoundation/raha-web-app/pull/183#pullrequestreview-151660588, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPIBTiRgzDkBXyNOtJqHS3-5E52CRhGks5uXLk9gaJpZM4WW0No .

    rahulgi commented 6 years ago

    Oh, I just mean a comment for internal consumption. I haven't been following the issues around https and custom schema deeplinking, so I think it would be useful to have that context when we revisit this.

    tinaroh commented 6 years ago

    I won't have access to my laptop today. I can make the change tomorrow but if mark is going to invite more people today, please merge and deploy for me and I'll follow up tomorrow.

    On Mon, Sep 3, 2018, 2:14 PM Rahul Gupta-Iwasaki notifications@github.com wrote:

    Oh, I just mean a comment for internal consumption. I haven't been following the issues around https and custom schema deeplinking, so I think it would be useful to have that context when we revisit this.

    — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahafoundation/raha-web-app/pull/183#issuecomment-418002119, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPIBaIypJp4V7HC7n7tX2nav5vvA2Qkks5uXLqdgaJpZM4WW0No .

    tinaroh commented 6 years ago

    context is available in the Slack thread in dev-troubleshooting if you want to know right away.

    On Mon, Sep 3, 2018, 2:15 PM Tina Roh tinaroh@gmail.com wrote:

    I won't have access to my laptop today. I can make the change tomorrow but if mark is going to invite more people today, please merge and deploy for me and I'll follow up tomorrow.

    On Mon, Sep 3, 2018, 2:14 PM Rahul Gupta-Iwasaki notifications@github.com wrote:

    Oh, I just mean a comment for internal consumption. I haven't been following the issues around https and custom schema deeplinking, so I think it would be useful to have that context when we revisit this.

    — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahafoundation/raha-web-app/pull/183#issuecomment-418002119, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPIBaIypJp4V7HC7n7tX2nav5vvA2Qkks5uXLqdgaJpZM4WW0No .