search

rahafoundation / raha-web-app

The Raha identity network supporting universal basic income.
https://web.raha.app
Apache License 2.0
10 stars 3 forks source link

add internationalization support #40

Closed kem226 closed 6 years ago

kem226 commented 6 years ago

Added use of the Library https://github.com/yahoo/react-intl for internationalization support. Currently only english support but allows us to store strings in a separate file that can also be translated later as we want to support more languages.
issue #26

markulrich commented 6 years ago

Ready for land after conflicts resolved

ataki commented 6 years ago

whoops, we have to adapt the tests to work with internationalization. Will plan to work on that today unless you guys know of a quick-fix.

If not, since I don't want that to be a blocker for this PR, might I suggest we remove the internationalization component from the RequestInviteForm component for now? We can add back in once tests have been adapted.

ataki commented 6 years ago

followed @markulrich's link and added intl-enzyme-test-helper to the repo. we're not currently testing i18n translations, but this sets us up to be able to provide messages to an IntlProvider and ensure it works.

markulrich commented 6 years ago

Awesome, thank @ataki !!

markulrich commented 6 years ago

Hit close instead of merge ... facepalm