search

rahhulleee / pe

0 stars 0 forks source link

Duplicate Emails are allowed #1

Open rahhulleee opened 5 months ago

rahhulleee commented 5 months ago

image.png

2 different users are allowed to have the same email id which should not be the case as emails are supposed to be unique. as shown in the picture

nus-pe-script commented 5 months ago

Team's Response

There is no reason for us to implement overzealous input validation. Allowing such flexibility can in turn allow the user to use the software in their own preference while overzealous rejection of inputs can annoy the user.

Especially since it is possible for people to share the same email, it is better to accept than cause problems of rejecting

https://nus-cs2103-ay2324s2.github.io/website/admin/tp-pe.html#feature-flaws-2

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: This is not an overzealous input validation but rather an issue of allowing something that cannot be a duplicate in real life context. And as mentioned in my response regarding your future plans, it has to be specified clearly that email is another field to take into account for duplicate validation in the future.