search

rahhulleee / pe

0 stars 0 forks source link

2. Duplicate phone numbers allowed for users #2

Open rahhulleee opened 3 months ago

rahhulleee commented 3 months ago

image.png

Similarly, identical phone numbers are allowed for multiple users but phone numbers in real life context are unique

nus-pe-script commented 3 months ago

Team's Response

There is no reason for us to implement overzealous input validation. Allowing such flexibility can in turn allow the user to use the software in their own preference while overzealous rejection of inputs can annoy the user. For example, it might be possible for clients to share the same number and hence we do not wish to restrict this possibility.

However we believe that this is NotInScope, as the effort to implement a warning feature to allow users to confirm if they wish to add duplicate phone numbers is outweighed by the importance of implementing the rest of our features for v1.4.

https://nus-cs2103-ay2324s2.github.io/website/admin/tp-pe.html#feature-flaws-2

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Once again I refer to my response to issue 7:

You didn't specify which are the fields that are going to be used for duplicate checking in the future development plans and hence, I have to reject this. Phone numbers are indeed unique to a single Person after research online and hence (even though this is of low severity), specificity for the fields going to be used in duplicate checks for the future development plans is required as this is indeed a problem in a real life context (where people have unique emails and phone numbers).