rahhulleee / pe

0 stars 0 forks source link

3. No Limits on income #3

Open rahhulleee opened 5 months ago

rahhulleee commented 5 months ago

image.png

A very large and unrealistic income level is allowed in the application

nus-pe-script commented 5 months ago

Team's Response

There is no reason for us to implement overzealous input validation. Allowing such flexibility can in turn allow the user to use the software in their own preference while overzealous rejection of inputs can annoy the user.

https://nus-cs2103-ay2324s2.github.io/website/admin/tp-pe.html#feature-flaws-2

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Once again similar to the invalid phone number explanation,

The whole application might be affected as a very long and overzealous input will make the box containing Client information very big and long, and readability might be affected.

image.png

The example of an overzealous input provided is fine as it is harmless to the UI. However look at this example.

image.png

The entire UI is affected and readability of the application is affected. I believe that there should be a reasonable limit placed on the number of characters allowed - and this would help in validity checking as well. Lets say there's a corruption of your income level or phone number and this long number is what the phone number becomes. There is obviously a corruption and the limit should allow for the validity of the data to be ensured as well. In retrospect, what if allowing this long number and hence the UI bugs and unreadability annoy the user instead. Once again I am reiterating how realistic the overzealous inputs have to be. The example provided above is indeed pretty realistic but a VERY and UNREALISTICALLY long phone number shouldn't be allowed. :DD

UI shouldn't be forsaken at the expense of allowing overzealous input to not make the user annoyed