rahhulleee / pe

0 stars 0 forks source link

8. Preservation of index #8

Open rahhulleee opened 2 months ago

rahhulleee commented 2 months ago

image.png

Above, I added a new client "A" and has the index 3.

After sorting and deleteing B, preservation is not presererd.

image.png

nus-pe-script commented 2 months ago

Team's Response

To clarify, the indices in our list is to number the entries and indicate their position in the list of clients. It is not tagged to any specific persons.

What your screenshots displayed is the expected sort behaviour. Using sort will change the order as expected and each client will have a new index based on the implemented logic of sort.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hi just to clarify my point,

1)the initial picture shows all the INITIAL indexes of the Clients in your application. 2) Once i use the sort function, the indexes change in a sorted function (this is according to your functionality) 3) However, once I use "list" again after the sorting, the indexes of the Clients now follow the indexes of your sorted list. The initial ordering before of the sorting is lost. The initial state of your addressbook is changed by the sort method and this changing of state is not highlighted in your UG or DG.

You should explicitly state "once you use sort, all the indexes of Clients will follow the sorted list from thereon" if this is intended

Pictures to elaborate :

1) Before sorting, as you can see Client 4 has a birthday and Client 3 doesnt:

image.png

2) After sorting, and i use the list command:

image.png

As you can see, now Rah is in position 1, and there's a state change (i am out of the sorting view and now in the list view). Once I exit and re-enter the app, the indexes still follow the sorted manner. You should include this in the documentation.