search

rahims / SoCo

SoCo (Sonos Controller) is a simple Python class that allows you to programmatically control Sonos speakers.
329 stars 34 forks source link

Unittests #17

Closed KennethNielsen closed 11 years ago

KennethNielsen commented 11 years ago

I have implemented the first three unittests and some commandline code for the unittest module. Let me know what you think of the structure. I'm a litle new to github, but I will try to figure out how to link to this pull request in the issue.

KennethNielsen commented 11 years ago

Ahh, the issues automatically turns into issues. Lesson learned. Anyway, I have implemented unit tests for the first 3 methods in SoCo. They are not exhaustive, but before more tests are added for these methods it will be necessary to discuss if and how to handle input of wrong types.

Let me know what you think.

KennethNielsen commented 11 years ago

Let us not merge this request until I have more unit tests finished, but let us keep the pull request open, so that we can tell that they are being worked on.

KennethNielsen commented 11 years ago

Since we are moving. Let's close this one and I will reopen on the new location when I have enough to want to merge.