search

rahuldkjain / github-profile-readme-generator

🚀 Generate GitHub profile README easily with the latest add-ons like visitors count, GitHub stats, etc using minimal UI.
https://rahuldkjain.github.io/gh-profile-readme-generator
Apache License 2.0
21.3k stars 6.67k forks source link

Hugging Face SVG Icon #705

Open dpearson00 opened 1 year ago

dpearson00 commented 1 year ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] You do not have a svg file for hugging face.

Describe the solution you'd like A clear and concise description of what you want to happen. I would like to add it to the social directory

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. N/A

Additional context Add any other context or screenshots about the feature request here. I accidentally submitted a pull request with the changes before I created the issue and got approval. My apologies, this is my first time contributing to someone else's project.

Join the Discord Server for further discussions.

GPRG Discord Server Link

Server Link: https://discord.gg/HHMs7Eg

nik132-eng commented 1 year ago

can you please assign me this issue?

dpearson00 commented 1 year ago

nik132-eng: Please excuse my lack of experience here, but could you explain why do you want me to assign this issue to you? And how would I go about assigning it to you?

Thank you

nik132-eng commented 1 year ago

if you are a maintainer, most open-source projects have a pattern if there are exciting issues new people come and ask to assign that person so everyone is not working and maintainers have an excellent way to maintain a project.

dpearson00 commented 1 year ago

If I am understanding you correctly, it sounds like you would like to be the one to work on this issue? If this is correct, I have already done the work. I actually did it and submitted it before creating an issue. I then read how to properly contribute to this open source project and was suppose to create this issue first. I went ahead and created the issue after the fact.

Here is a link to the pull request I submitted. It was not merged because no one has reviewed it and I am unsure why this has happened. Would you happen to know why or how to get it reviewed?

Thank you for your patience and explaining this to me.

https://github.com/rahuldkjain/github-profile-readme-generator/pull/706