rahuldkjain / github-profile-readme-generator

🚀 Generate GitHub profile README easily with the latest add-ons like visitors count, GitHub stats, etc using minimal UI.
https://rahuldkjain.github.io/gh-profile-readme-generator
Apache License 2.0
20.47k stars 6.28k forks source link

Delete underscore near logos #807

Open AFimiani opened 4 months ago

AFimiani commented 4 months ago

Description

The logos in the README.md have underscores near them, which aesthetically would look better without them.

Possible Implementation

I managed to achieve the same result by using Markdown syntax instead of HTML for embedding the images with links. Here's how I did it:

Before:
<a href="https://www.example.com" target="_blank" rel="noreferrer"> <img src="logo_url" alt="logo_with_underscore" width="40" height="40"/> </a>

After:
[<img src="logo_url" alt="logo without underscore" width="40" height="40"/>](https://www.example.com)

By using Markdown syntax, I was able to remove the underscores from the alt text of the images, maintaining the href functionality and the desired dimension of the icon

g-savitha commented 4 months ago

Would you like to work on this? @AFimiani

prabhanshjn commented 4 months ago

Hi @g-savitha , I can try to work on this issue. Can you assign it to me. Thanks

prabhanshjn commented 4 months ago

Hi @g-savitha , I have solved the issue and created a PR: #812 Please check it out, Thanks!