search

rahulhaque / laravel-filepond

Use FilePond the Laravel way.
MIT License
185 stars 31 forks source link

Use of union types causes a breaking change #49

Closed Pheasey closed 11 months ago

Pheasey commented 11 months ago

Changes made in https://github.com/rahulhaque/laravel-filepond/commit/fb9891644b689a6c85e2b1a676845e29d3e7d904 add union types to several method arguments so the project no longer works with PHP 7.3.

This is still an option defined in the composer.json so should be amended or reverted depending on the desired supported versions.

rahulhaque commented 11 months ago

Hi @Pheasey, thanks for the report. You're using it in Laravel 7 project right? I am thinking about updating the minimal PHP version to 7.4. Will that be okay with you?

Edit: I've updated the minimal PHP version support to 7.4. Please run composer update to fetch the latest changes. Thank you.

Pheasey commented 11 months ago

@rahulhaque Union types are a PHP 8 feature, this can be seen in the change log so you would need to drop 7.4 support too.

rahulhaque commented 11 months ago

@Pheasey you're right. I missed it and completely forgot when adding support for newest Laravel release. It started with me adding pint for code formatting. This version supposed to support Laravel 8 and onwards. Thanks for reporting. I'll be releasing a new version soon.

rahulhaque commented 11 months ago

@Pheasey I've moved to the major versioning aligned with major Laravel release. Please, do report if you find anything unusual. Thank you for this.