rahuliyer95 / iShowcase

Highlight the best parts of your application
MIT License
65 stars 25 forks source link

Circular type... #15

Closed nishal closed 7 years ago

nishal commented 7 years ago

Thanks for the great library.

When a rectangle type is applied to a view, the rectangles inner box fits the entire view it is placed on. However, for the case of the circle type, it seems like the outer circle diameter becomes the width or height of the view it is applied on. Wondering if this can be modified to have the inner circle diameter set to sqrt((view.width)^2 + (view.height)^2)? This will ensure that the whole view is encircled.

rahuliyer95 commented 7 years ago

Hi,

Apologies for the late reply. You can try this out in the example app where the custom iShowcase shows a circular one and set the radius there. The radius property is exposed for such purposes.

On Tue 7 Mar, 2017, 4:22 AM nishal, notifications@github.com wrote:

Thanks for the great library.

When a rectangle type is applied to a view, the rectangles inner box fits the entire view it is placed on. However, for the case of the circle type, it seems like the outer circle diameter becomes the width or height of the view it is applied on. Wondering if this can be modified to have the inner circle radius set to sqrt((view.width)^2 + (view.height)^2)? This will ensure that the whole view is encircled.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rahuliyer95/iShowcase/issues/15, or mute the thread https://github.com/notifications/unsubscribe-auth/AEDvZqkR00OzpP_HSUqxkOLEbCFViNmcks5rjI4ugaJpZM4MUznQ .

--

Regards, Rahul Iyer