rahuljai-05 / pe

0 stars 0 forks source link

No way to view or edit universities list #11

Open rahuljai-05 opened 6 days ago

rahuljai-05 commented 6 days ago

Currently there seems to be no way for the administrators to edit or view the university list which could be an issue for administrators especially when using functions which use the university index such as ViewQuota.

soc-se-bot commented 3 days ago

Team's Response

We take it that the University List is final already so no additional changes are required, also this application is built for simplifying the allocation process for the administrators. Furthermore, it is given that the administrators already have the list of Universities and their indexes, because that was what we referenced when building the list. Also, we felt that if we had a function to print out the list of universities may not be the most ideal, as we would be flooding the terminal with at least 92 lines every time they want to see the list of universities.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** The severity should not be VeryLow I feel as it has been clearly stated in the course website that this severity can be assigned to issues that have a cosmetic impact only. Looking back, I think the severity should be medium. ![image.png](https://raw.githubusercontent.com/rahuljai-05/pe/main/files/7b4a2fbd-b3d6-4e01-b763-2e9e66dcdaa5.png) The team is likely to have fetched the data for the universities' list from the following page : https://ceg.nus.edu.sg/wp-content/uploads/sites/4/2024/08/CEG-AY2526-SEP-Round-1-Places.pdf It is assumed that the administrators also have access to this list of universities only. However, as you can see from the below screenshot, there is no university index for each university mentioned in the official page. These seem to have been allocated by the developer team themselves after pasting the table of content on excel maybe or simply by assigning the indices in increasing order starting from 1, to every university. ![Screenshot 2024-11-21 234126.png](https://raw.githubusercontent.com/rahuljai-05/pe/main/files/4e56c44f-28e6-4b76-a940-f891641eccd0.png) ![Screenshot 2024-11-21 235042.png](https://raw.githubusercontent.com/rahuljai-05/pe/main/files/53b3f51b-e7d4-4490-8784-4cb75a9b4d97.png) Since these indices have been fabricated and assigned by the developer team itself, I feel like this may still cause some confusion to the admins who will be using this app for the first time since they cannot immediately find out which index corresponds to which university from a first glance at the table itself. They will have to put it into an excel sheet or something similar so that they can see the indices starting from 1. This should have at least been mentioned in the DG to make the app more user friendly and optimized for the admins. An alternative which the team could have considered would have been to simply use the external organization id's circled in blue as the keys for the UniversityRepository HashMap. In this case, they wouldn't have had to fabricate any indices themselves and this organization id feels more natural as well as they will be used by the admins in others places also to refer to the university.