search

rahuljai-05 / pe

0 stars 0 forks source link

Add Command sequence diagram #9

Open rahuljai-05 opened 6 days ago

rahuljai-05 commented 6 days ago

Screenshot 2024-11-15 173259.png

Unsure of why the specific example input for parseInput() has been included in the UML diagram. could be misleading to users by indicating that it is a default value.

nus-pe-script commented 3 days ago

Team's Response

Thanks for raising this issue. We will be rejecting this issue because it is clearly stated right above the diagram that "Whenever the user enters an input, the input will be directed to the Parser class’s parseInput() method". It was also mentioned that the following sequence diagram is depicting an example where the user key in add id/A1234567I gpa/5.0 p/{13,61,43} into the terminal.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png

While the team using a specific example input by itself could be fine, the team has responded by saying that the sequence diagram demonstrates the add command for an id : "A1234567I" (refer to the highlighted portion of the screenshot given above). But, in the sequence diagram, the id is "A1234567J" (refer to the blue circled portion of the original bug report). This seems to be a small typo where the "I" has been replaced with a "J" in the sequence diagram but I do believe it is still a valid severity.VeryLow bug as mentioned in the course website.

image.png

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]