rahulkapoor90 / VITacademics-Enhancement-Suite

:sunglasses: Extension to enhance your browsing experience on VIT Academics Student Login.
http://bit.ly/28Pe4ah
GNU Affero General Public License v3.0
22 stars 8 forks source link

Fix notifications for marks change and new messages #12

Closed hvarday closed 7 years ago

hvarday commented 7 years ago

Previously written code for marks change and notification has bugs and is currently commented out, requires refactoring and proper documentation.

Bugs -

rahulkapoor90 commented 7 years ago

Also:

Things to do:

Include the assets locally in the addon for firefox and chrome. Add support for opera. Make firefox extension stable. * currently unstable. Improve the bad code written in chrome extension.

hvarday commented 7 years ago

Will add another issue to refactor every script and add documentation.

what assets are you talking about, the icons and images?

How different is opera, firefox extension development compared to chrome extension development?

rahulkapoor90 commented 7 years ago

yes, icons and images, firefox requires to host images locally and i think it's better to do the same with chrome extension as these might get deleted from imgur or vit.ac.in

hvarday commented 7 years ago

True, also they being local would save some time downloading it on client side

rahulkapoor90 commented 7 years ago

yet they will increase the the extension size from currently 200kb to 1mb maybe more.

hvarday commented 7 years ago

If there is size issue, we can upload it on Cloudinary, and so the concern about resources getting deleted will be solved.

rahulkapoor90 commented 7 years ago

yeah nice idea.

hvarday commented 7 years ago

I was thinking about 2 features:

rahulkapoor90 commented 7 years ago

Okay, will work on that. Can you create a todo file on main page on this repo with the things that could be added.

hvarday commented 7 years ago

Yep

rahulkapoor90 commented 7 years ago

Done & dusted by @lakshaykapoor7198