search

rahulkapoor90 / VITacademics-Enhancement-Suite

:sunglasses: Extension to enhance your browsing experience on VIT Academics Student Login.
http://bit.ly/28Pe4ah
GNU Affero General Public License v3.0
22 stars 8 forks source link

Enhanced file structure for development version of VES. #2

Closed uppusaikiran closed 8 years ago

uppusaikiran commented 8 years ago

Introduction

Instead of putting all the style sheets and scripts files in the root folder,it is better to move each file to separate folder which helps developers able to understand what really the functionality of each module.

Things Done

  1. Moved image assets to separate folders.
  2. Main scripts are moved to scripts folder.
  3. Entire background scripts are separated from base scripts and moved to background folder.
  4. 2 Versions(Both Prod and Dev) of captcha.js is added.
  5. Multiple DOM referencing is replaced with single DOM call and traversal functionality.
  6. Instead of jquery.js a minified jquery.min.js is added for production environment.
  7. Moved all the style-sheets to respective folders based on their usage.
  8. Updated manifest file matching the modified changes.
  9. Jquery functionality was added to options.js.

    Things yet to do

  10. Change Main.js file and update functionality with jquery.
  11. Move files to corresponding folders.
  12. Remove css bugs in course page.
  13. Remove bugs introduced due to moving files.
rahulkapoor90 commented 8 years ago

@uppusaikiran Thanks for the PR! can you see and explain why there is no css for popup as it was there earlier and if there are any other major changes, please highlight it below.

hvarday commented 8 years ago

@uppusaikiran , Great work.. Much appreciated! I found this bug,

couldn't include calc.js ( change of path required )

uppusaikiran commented 8 years ago

Thanks @rahulkapoor90 and @hvarday for your response.

When modifying the file structure in a customized manner took some time as it has lot of referencing and files.Initially i have moved assets like images and css files seperately.Later i started working on scripts.This resulted in some bugs and majority of which are rectified previously.

Bug Fix - #1 (couldn't include calc.js ) by @hvarday

The path of calc.js file in the web accesable resources is changed.

Bug Fix - #2 (no css for popup) by @rahulkapoor90

The href value points to invalid loacation and now fixed.And now popup has css.

rahulkapoor90 commented 8 years ago

@uppusaikiran okay, i accepted your pull request.

uppusaikiran commented 8 years ago

@rahulkapoor90 Thanks for accepting the pull request.

rahulkapoor90 commented 8 years ago

No problem, keep on working on your other TODO items i will accept those too if they are good enough.