Closed craigpullar closed 6 years ago
So the docker image never actually installed Yarn, which meant our scripts wouldn’t run. So I opted to use npm inside the docker container instead of installing Yarn. I prefer yarn but since it’s going to be run by docker I didn’t care so much, if we want to use yarn it’s not a big change though :) On Sat, Sep 22, 2018 at 11:19 PM, Rahul Ramesh notifications@github.com wrote:
@rahulramesh8 approved this pull request.
Looks solid man 🚀 🚀 First official PR in the books!
Just one quick question, is there a reason the yarns are changed to npms? More out of curiosity than anything
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahulramesh8/polyserv/pull/10#pullrequestreview-157927619, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAMQGFA93DTNYBLmICBVRQJ3HD7eCXFks5udv2wgaJpZM4W1ciu .
@rahulramesh8 So I ended up just installing Yarn :call_me_hand: