search

rahulsain / MemeIt

Meme Sharing app with the functionality of sharing image of the given meme that is being fetched by reddit using API. Learned Volley, Glide Library, Volley Singleton Class and Glide Response Library.
0 stars 1 forks source link

Madhurs Commit #10

Closed mjmadhur closed 3 years ago

mjmadhur commented 3 years ago

Hello Rahul in changes i made ,i focused on making Ui attractive by adding some decent background and a splash screen to let the person know he is entering into which APP. i also added a share button in menu itself so that if person forgets the gesture feature he can click on that to share meme.Thats all i have done. Thank You!! it is my first pr if any mistake plss tell. also plss add username mjmadhur to contributors list if u approve this commit

rahulsain commented 3 years ago

Please attach an apk here too

mjmadhur commented 3 years ago

Plss can u tell how to attach it. Do i have to make a new pr

mjmadhur commented 3 years ago

Plss tell how to attach apk would it work without apk plss.?

On Sat, 2 Oct, 2021, 14:26 Rahul Sain, @.***> wrote:

Please attach an apk here too

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-932717592, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G5K2PU3ML4C5SXE5HLUE3CNLANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mjmadhur commented 3 years ago

Merge the pull request buddy..

On Sat, 2 Oct, 2021, 19:26 madhur jain, @.***> wrote:

Plss tell how to attach apk would it work without apk plss.?

On Sat, 2 Oct, 2021, 14:26 Rahul Sain, @.***> wrote:

Please attach an apk here too

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-932717592, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G5K2PU3ML4C5SXE5HLUE3CNLANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

rahulsain commented 3 years ago

Plss can u tell how to attach it. Do i have to make a new pr

No, you have to attach the debug apk here, in the comment section. You can drag and drop the apk file here

mjmadhur commented 3 years ago

Ok, will do that. Build apk will work...

On Sun, 3 Oct, 2021, 07:31 Rahul Sain, @.***> wrote:

Plss can u tell how to attach it. Do i have to make a new pr

No, you have to attach the debug apk here, in the comment section. You can drag and drop the apk file here

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-932848397, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G3C3DZ6VCESOBC6YFDUE62O5ANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mjmadhur commented 3 years ago

here is the apk bro .was unable to attach in comments sorry for that..plss merge pr .. app-debug.apk https://drive.google.com/file/d/1m3MQbOrepCJ2T4yw4nLG_UnWWNFCGtDz/view?usp=drive_web

On Sun, Oct 3, 2021 at 7:43 PM madhur jain @.***> wrote:

Ok, will do that. Build apk will work...

On Sun, 3 Oct, 2021, 07:31 Rahul Sain, @.***> wrote:

Plss can u tell how to attach it. Do i have to make a new pr

No, you have to attach the debug apk here, in the comment section. You can drag and drop the apk file here

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-932848397, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G3C3DZ6VCESOBC6YFDUE62O5ANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

rahulsain commented 3 years ago

Why the splash screen and the background image of the memes are stretched?

rahulsain commented 3 years ago

I have added the labels now, it will show in your hacktoberfest progress, but do the required changes so that I can merge your PR

mjmadhur commented 3 years ago

Bcoz if I added only image as src it would not acquire the full screen

On Sun, 3 Oct, 2021, 20:45 Rahul Sain, @.***> wrote:

Why the splash screen and the background image of the memes are stretched?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-932971370, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G3PLMHIVZWFF5S6WBLUFBXPRANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mjmadhur commented 3 years ago

The splash screen is stretched only to make it look good otherwise it will be small

On Sun, 3 Oct, 2021, 20:48 Rahul Sain, @.***> wrote:

I have added the labels now, it will show in your hacktoberfest progress, but do the required changes so that I can merge your PR

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-932971860, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G3FCL3UXVUKSROQ45DUFBX2VANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mjmadhur commented 3 years ago

But it looks good according to me

On Sun, 3 Oct, 2021, 20:53 madhur jain, @.***> wrote:

The splash screen is stretched only to make it look good otherwise it will be small

On Sun, 3 Oct, 2021, 20:48 Rahul Sain, @.***> wrote:

I have added the labels now, it will show in your hacktoberfest progress, but do the required changes so that I can merge your PR

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-932971860, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G3FCL3UXVUKSROQ45DUFBX2VANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

rahulsain commented 3 years ago

But it looks good according to me … On Sun, 3 Oct, 2021, 20:53 madhur jain, @.> wrote: The splash screen is stretched only to make it look good otherwise it will be small On Sun, 3 Oct, 2021, 20:48 Rahul Sain, @.> wrote: > I have added the labels now, it will show in your hacktoberfest progress, > but do the required changes so that I can merge your PR > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#10 (comment)>, or > unsubscribe > https://github.com/notifications/unsubscribe-auth/AVKN2G3FCL3UXVUKSROQ45DUFBX2VANCNFSM5FFHO2DA > . > Triage notifications on the go with GitHub Mobile for iOS > https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 > or Android > https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. > >

image use this

mjmadhur commented 3 years ago

i have made the chANGES and changes the scale type of splashscreen to centreCrop . thank uh!! now can uh Merge!!?

rahulsain commented 3 years ago

i have made the chANGES and changes the scale type of splashscreen to centreCrop . thank uh!! now can uh Merge!!?

with every changes, provide apk with it. You can drag and drop that apk file in this comment section

mjmadhur commented 3 years ago

Wait I just mail uh.

On Mon, 4 Oct, 2021, 10:14 Rahul Sain, @.***> wrote:

i have made the chANGES and changes the scale type of splashscreen to centreCrop . thank uh!! now can uh Merge!!?

with every changes, provide apk with it. You can drag and drop that apk file in this comment section

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-933139169, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G4QIY7ZJ3MHMK4AO23UFEWKXANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mjmadhur commented 3 years ago

app-debug(modified).apk https://drive.google.com/file/d/1CrhsNWgKJs3O0bRpQLlQVjP1T0x4Zt02/view?usp=drive_web here is modified apk bro

On Mon, Oct 4, 2021 at 11:06 AM madhur jain @.***> wrote:

Wait I just mail uh.

On Mon, 4 Oct, 2021, 10:14 Rahul Sain, @.***> wrote:

i have made the chANGES and changes the scale type of splashscreen to centreCrop . thank uh!! now can uh Merge!!?

with every changes, provide apk with it. You can drag and drop that apk file in this comment section

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-933139169, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G4QIY7ZJ3MHMK4AO23UFEWKXANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mjmadhur commented 3 years ago

Is everything ok with apk i sent?!

rahulsain commented 3 years ago

Make a check when we have gif image then the share button should be invisible

rahulsain commented 3 years ago

Make a check when we have gif image then the share button should be invisible

and the images are not suitable for phone view but not a big issue over there

mjmadhur commented 3 years ago

Let's make it visible it won't create much difficulty hiding it for sometime does not give a sense I think. And while loading it will share the most previous meme only. So i think no effect of making it invisible

On Tue, 5 Oct, 2021, 12:58 Rahul Sain, @.***> wrote:

Make a check when we have gif image then the share button should be invisible

and the images are not suitable for phone view but not a big issue over there

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-934141988, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G76UYNBCTSP76QSMQTUFKSLDANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mjmadhur commented 3 years ago

Which images the memes ones. ? They are in png format so what's difficulty

On Tue, 5 Oct, 2021, 12:58 Rahul Sain, @.***> wrote:

Make a check when we have gif image then the share button should be invisible

and the images are not suitable for phone view but not a big issue over there

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-934141988, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G76UYNBCTSP76QSMQTUFKSLDANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mjmadhur commented 3 years ago

They are suitable I have the app in my phone

On Tue, 5 Oct, 2021, 12:58 Rahul Sain, @.***> wrote:

Make a check when we have gif image then the share button should be invisible

and the images are not suitable for phone view but not a big issue over there

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-934141988, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G76UYNBCTSP76QSMQTUFKSLDANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

rahulsain commented 3 years ago

Which images the memes ones. ? They are in png format so what's difficulty … On Tue, 5 Oct, 2021, 12:58 Rahul Sain, @.***> wrote: Make a check when we have gif image then the share button should be invisible and the images are not suitable for phone view but not a big issue over there — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G76UYNBCTSP76QSMQTUFKSLDANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

no this app also display .gif files too, if you check some .gif subreddit you will see, sharing .gif is not implemented yet

rahulsain commented 3 years ago

user cant share .gif files yet, maybe you can take up this issue as well

mjmadhur commented 3 years ago

Okkk bro i will take but actually I m out of station so plss u merge this pr. Then I will create new pr for gif sharing by Friday.. Please!

On Tue, 5 Oct, 2021, 13:16 Rahul Sain, @.***> wrote:

user cant share .gif files yet, maybe you can take up this issue as well

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-934153429, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G7VPBAWVX5LFJORV53UFKUMLANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mjmadhur commented 3 years ago

Please merge the first pr I will create new one for gif share👏

rahulsain commented 3 years ago

Sure, just make a check if current image is gif then make share btn invisible

On Tue, 5 Oct, 2021, 1:19 pm Madhur jain, @.***> wrote:

Please merge the first pr I will create new one for gif share👏

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-934155605, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMB2LNMEFXDZ6FA2T3LMFUDUFKUY3ANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mjmadhur commented 3 years ago

I will do it in the pr where I will add gif share feature.. Firstly plss merge this one 👏🤘

On Tue, 5 Oct, 2021, 13:29 Rahul Sain, @.***> wrote:

Sure, just make a check if current image is gif then make share btn invisible

On Tue, 5 Oct, 2021, 1:19 pm Madhur jain, @.***> wrote:

Please merge the first pr I will create new one for gif share👏

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-934155605, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AMB2LNMEFXDZ6FA2T3LMFUDUFKUY3ANCNFSM5FFHO2DA

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/rahulsain/MemeIt/pull/10#issuecomment-934162807, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G3GNFJ7YB2UPWYK7ULUFKV7ZANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

rahulsain commented 3 years ago

I will do it in the pr where I will add gif share feature.. Firstly plss merge this one 👏🤘 … On Tue, 5 Oct, 2021, 13:29 Rahul Sain, @.> wrote: Sure, just make a check if current image is gif then make share btn invisible On Tue, 5 Oct, 2021, 1:19 pm Madhur jain, @.> wrote: > Please merge the first pr I will create new one for gif share👏 > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#10 (comment)>, or > unsubscribe > < https://github.com/notifications/unsubscribe-auth/AMB2LNMEFXDZ6FA2T3LMFUDUFKUY3ANCNFSM5FFHO2DA > > . > Triage notifications on the go with GitHub Mobile for iOS > < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 > > or Android > < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub >. > > — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKN2G3GNFJ7YB2UPWYK7ULUFKV7ZANCNFSM5FFHO2DA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

are you working on this now?