search

rahulsain / SharedNotes

Created an Android app that helps organisation to share notes with each other. Built with Firebase
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Making User Profile better with some errior validation and adding new features #29

Closed cdhiraj40 closed 2 years ago

cdhiraj40 commented 2 years ago

The user profile Activity currently doesn't have proper errors/toast to show which can definitely increase user experience

cdhiraj40 commented 2 years ago

hey, @rahulsain can I work on it under the hacktoberfest label?

rahulsain commented 2 years ago

What errors or toast exactly you want to add?

cdhiraj40 commented 2 years ago

What errors or toast exactly do you want to add?

I actually have many whichever you want me to work on I can

1) if you click on reset password and if it doesn't have any password/logged in then it should give a toast to it 2) direct click on the user profile photo rather than going into change profile and change it. 3) edit profile already has texts and having some texts in the edit text field is not good as the person has to remove the text and then add it and when you click on save there are also some things I would like to change according to this 4) verify email also has the same thing as reset password

rahulsain commented 2 years ago

There are toasts for no 1 and 4.

No need for no 2

No 3 is required when we edit the fields from second time onwards

On Tue, 5 Oct, 2021, 1:40 pm Dhiraj Chauhan, @.***> wrote:

What errors or toast exactly do you want to add?

I actually have many whichever you want me to work on I can

  1. if you click on reset password and if it doesn't have any password/logged in then it should give a toast to it
  2. direct click on the user profile photo rather than going into change profile and change it.
  3. edit profile already has texts and having some texts in the edit text field is not good as the person has to remove the text and then add it and when you click on save there are also some things I would like to change according to this
  4. verify email also has the same thing as reset password

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rahulsain/SharedNotes/issues/29#issuecomment-934171024, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMB2LNKDNR3K3SKJJZ74PQTUFKXITANCNFSM5FJZQNHA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

cdhiraj40 commented 2 years ago

There are toasts for no 1 and 4. No need for no 2 No 3 is required when we edit the fields from second time onwards … On Tue, 5 Oct, 2021, 1:40 pm Dhiraj Chauhan, @.***> wrote: What errors or toast exactly do you want to add? I actually have many whichever you want me to work on I can 1. if you click on reset password and if it doesn't have any password/logged in then it should give a toast to it 2. direct click on the user profile photo rather than going into change profile and change it. 3. edit profile already has texts and having some texts in the edit text field is not good as the person has to remove the text and then add it and when you click on save there are also some things I would like to change according to this 4. verify email also has the same thing as reset password — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMB2LNKDNR3K3SKJJZ74PQTUFKXITANCNFSM5FJZQNHA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

no, but it still lets people click on the button and the dialog box opens it should directly say on click why letting people type all fields and then show a toast the same thing is when we click on change profile after filling all the data it shows u need to be registered first, its better to show it when they click if the change is not gonna happen

rahulsain commented 2 years ago

I have implemented that way, because in future users have to logged in to access.

Thats why it is easier to maintain the code without changing much

cdhiraj40 commented 2 years ago

I have implemented that way because in the future users have to log in to access.

That's why it is easier to maintain the code without changing much

okay I understand your implementation, so are there features that you recommend I should work on I would love to contribute, thanks :)

rahulsain commented 2 years ago

I have implemented that way because in the future users have to log in to access. That's why it is easier to maintain the code without changing much

okay I understand your implementation, so are there features that you recommend I should work on I would love to contribute, thanks :)

Do you have knowledge of storing audio video type of files to some database (free basically)

cdhiraj40 commented 2 years ago

I have implemented that way because in the future users have to log in to access. That's why it is easier to maintain the code without changing much

okay I understand your implementation, so are there features that you recommend I should work on I would love to contribute, thanks :)

Do you know about storing the audio-video type of files to some database (free basically)

no sorry I currently don't have any knowledge about that :/