search

rahulsv / TwitterClient

0 stars 0 forks source link

Review my app of Twitter Client #1

Open rahulsv opened 11 years ago

rahulsv commented 11 years ago

Tim and Nathan,

Thanks for your help during office hours. My app is almost complete, please review. Also, I have a question about the following a. I could not get the soft keyboard to display. How to enable it? b. Sometimes when I go back to Timeline, it doesn't automatically refresh. The way I am doing is that I am calling ComposeActivity with startActivityForResult and upon return I am calling a refresh() method. I extracted the MyTwitterApp.getRestClient().getHomeTimeline code into a method and named it refresh. This works sometime but doesn't refresh sometimes.

/cc @nesquena @timothy1ee

nesquena commented 11 years ago

Hi Rahul,

a. I could not get the soft keyboard to display. How to enable it?

In the Android Virtual Device Manager, you can uncheck the Checkbox that says : "Hardware Keyboard Present" and then restart your AVD to see soft keyboard. When there's a hardware keyboard, soft doesn't show up.

b. Sometimes when I go back to Timeline, it doesn't automatically refresh.

This is a common issue, and its because when creating a new tweet it can sometimes take 2-3 seconds for the tweet to show up in the home timeline API. Hence it's a race condition. One approach is you can pass the tweet back in the bundle and then insert it in the timeline onActivityResult.

Let us know if you have any other questions in particular. Looks good overall.

rahulsv commented 11 years ago

Nathan,

a. Your tip worked. Soft keyboard shows up. Thanks. b. I included a refresh button in the menu and that helped now.

Will update the repository.

nesquena commented 11 years ago

OK great, let us know if you have any other questions.