search

raicem / impulse-blocker

Block distracting websites when you are browsing the web. Use for procrastination.
https://blog.cemunalan.com.tr/2017/05/17/impulse-blocker-guide/
MIT License
169 stars 25 forks source link

Select blocking webpage from browser history #91

Closed hayribakici closed 1 year ago

hayribakici commented 3 years ago

Adresses #87 . This PR allows to users to add a page to the blocking list from the browser history.

raicem commented 2 years ago

Thank you @hayribakici, appreciate you taking the time to implement this. I like this feature but I really don't want to add new permission just for this feature. New history permission will open up this dialog to users and it is something I would like to avoid. Ideally, it should be done using the optional_permissions.

I could not build this without installing @babel/plugin-proposal-class-properties but maybe that's just me. The React component looks and works great but it is a class component and all of our code is using function components.

There are some other problems such as addresses appearing multiple times:

Screen Shot 2022-01-23 at 15 29 00

And many console log messages:

Screen Shot 2022-01-23 at 15 29 46

So I can't approve this right now, sorry.

hayribakici commented 2 years ago

hi, thank you for reviewing the code and addressing the problems. So using theoptional_permissions, users can decide, if they want to permit the extension to have the history-permission. So meaning, if they deny it, the extension should fall back to the regular input? Moreover, I tried to implement this feature regarding the functional components, however it quickly became a little messy, so outsourcing to its own class was the best option I could think of. Do you have any other ideas?

hayribakici commented 1 year ago

Reopened by #107, closing this PR.