search

raid-guild / moloch-minion

👹 Moloch whose fingers are ten armies!
35 stars 20 forks source link

Ui needs a way to tell when a dao has multiple minions. #72

Open dekanbro opened 4 years ago

dekanbro commented 4 years ago

The list of proposals from a dao is filtered on the proposal details field and if isMinion exists. There also needs to be a way to tell which minion in the case where a DAO has multiple minions.

dekanbro commented 4 years ago

this is probably related to #34

tarunbhm commented 4 years ago

In minion submitted proposal we have minion address as applicant so when we get list of proposals and see details field isMinion == true we can check for applicant address and based on that figure out which minion sent it. We can also use proposer field in proposal struct to check for it in case later on we want to specify applicant as actually user who created minion action from UI.

But that raises another question. Is there any specific reason behind keeping minion as applicant in proposals? it can cause issues later on when we want to automate grants proposal through a minion. If we keep minion as applicant then minion also needs to implement token transfer logic (pull pattern).