raiden-network / light-client

The Raiden Light Client
https://raiden.network/
MIT License
33 stars 31 forks source link

Fix subpaths version loading and deployment #3110

Closed andrevmatos closed 2 years ago

andrevmatos commented 2 years ago

Short description Ensure dApp instances deployed to subpaths (e.g. /v2 and /staging) don't get deleted when a root instance is deployed (on tag), and also ensure those subpaths instances have service-worker assistant disabled so it doesn't affect the main cached version.

Definition of Done

Steps to manually test the change (dApp)

1. 2.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3110 (ee290f5) into v2 (cc9c9ba) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##               v2    #3110   +/-   ##
=======================================
  Coverage   93.14%   93.14%           
=======================================
  Files         213      213           
  Lines        8590     8591    +1     
  Branches     1473     1474    +1     
=======================================
+ Hits         8001     8002    +1     
  Misses        530      530           
  Partials       59       59           
Flag Coverage Δ
dapp 88.83% <100.00%> (+<0.01%) :arrow_up:
dapp.unit 88.83% <100.00%> (+<0.01%) :arrow_up:
sdk 95.43% <ø> (ø)
sdk.e2e 72.57% <ø> (ø)
sdk.integration 79.51% <ø> (ø)
sdk.unit 49.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...iden-dapp/src/store/version-information/getters.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc9c9ba...ee290f5. Read the comment docs.