compojoom commented 2 years ago

Wrtc doesn’t seem to be supported anymore and the optional wrtc dependency in raiden-ts triggers an error during installation.

@andrevmatos you forgot to update the raiden-ts dependency. This fixes the error I get there during installation:

warning Error running install script for optional dependency: "/Development/light-client/node_modules/wrtc: Command failed.
Exit code: 1
Command: node scripts/download-prebuilt.js
Arguments:
Directory: /Users/dd/Development/light-client/node_modules/wrtc
Output:
node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using node-pre-gyp@0.13.0
node-pre-gyp info using node@14.18.2 | darwin | arm64
node-pre-gyp WARN Using request for node-pre-gyp https download
node-pre-gyp info check checked for \"/Development/light-client/node_modules/wrtc/build/Release/wrtc.node\" (not found)
node-pre-gyp http GET https://node-webrtc.s3.amazonaws.com/wrtc/v0.4.7/Release/darwin-arm64.tar.gz
node-pre-gyp http 404 https://node-webrtc.s3.amazonaws.com/wrtc/v0.4.7/Release/darwin-arm64.tar.gz
node-pre-gyp ERR! install error
node-pre-gyp ERR! stack Error: 404 status code downloading tarball https://node-webrtc.s3.amazonaws.com/wrtc/v0.4.7/Release/darwin-arm64.tar.gz
node-pre-gyp ERR! stack     at Request.<anonymous> (/Development/light-client/node_modules/node-pre-gyp/lib/install.js:149:27)
node-pre-gyp ERR! stack     at Request.emit (events.js:412:35)
node-pre-gyp ERR! stack     at Request.onRequestResponse (/Development/light-client/node_modules/request/request.js:1059:10)
node-pre-gyp ERR! stack     at ClientRequest.emit (events.js:400:28)
node-pre-gyp ERR! stack     at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:647:27)
node-pre-gyp ERR! stack     at HTTPParser.parserOnHeadersComplete (_http_common.js:127:17)
node-pre-gyp ERR! stack     at TLSSocket.socketOnData (_http_client.js:515:22)
node-pre-gyp ERR! stack     at TLSSocket.emit (events.js:400:28)
node-pre-gyp ERR! stack     at addChunk (internal/streams/readable.js:293:12)
node-pre-gyp ERR! stack     at readableAddChunk (internal/streams/readable.js:267:9)
node-pre-gyp ERR! System Darwin 21.5.0
node-pre-gyp ERR! command \"/.nvm/versions/node/v14.18.2/bin/node\" \"/Development/light-client/node_modules/wrtc/node_modules/.bin/node-pre-gyp\" \"install\"
node-pre-gyp ERR! cwd /Development/light-client/node_modules/wrtc
node-pre-gyp ERR! node -v v14.18.2

CLAassistant commented 2 years ago

All committers have signed the CLA.

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

codecov[bot] commented 2 years ago

Codecov Report

Merging #3159 (6f10f36) into fix/wrtc (25f3f4f) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##           fix/wrtc    #3159   +/-   ##
=========================================
  Coverage     94.10%   94.10%           
=========================================
  Files           213      213           
  Lines          7418     7418           
  Branches       1281     1281           
=========================================
  Hits           6981     6981           
  Misses          402      402           
  Partials         35       35

Flag	Coverage Δ
dapp	`89.93% <ø> (ø)`
dapp.unit	`89.93% <ø> (ø)`
sdk	`95.44% <ø> (ø)`
sdk.e2e	`72.32% <ø> (-0.20%)`	:arrow_down:
sdk.integration	`80.22% <ø> (ø)`
sdk.unit	`49.65% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25f3f4f...6f10f36. Read the comment docs.

raiden-network / light-client

Update the optional wrtc dep to @koush/wrtc #3159

Codecov Report