search

raiden-network / raiden-contracts

Raiden Network Smart Contracts
MIT License
53 stars 45 forks source link

deployment_*.json should contain the relevant hash of `contracts.json` #1309

Open pirapira opened 5 years ago

pirapira commented 5 years ago

Then an incident like https://github.com/raiden-network/raiden/issues/5122 can be prevented earlier. TravisCI can compare the hash stored in the deployment files against that stored in contracts.json.

When we upgrade only the service contracts, we do not want to deploy the other contracts. So the stored hash must not be overall_hash but the hashes of the relevant sources.

This means, each entry of contracts.json must contain a hash for each deployment file. Currently, service and raiden.

pirapira commented 5 years ago