search

raiden-network / raiden-contracts

Raiden Network Smart Contracts
MIT License
53 stars 45 forks source link

Test release process #446

Closed loredanacirstea closed 5 years ago

loredanacirstea commented 5 years ago

Test release process from https://github.com/raiden-network/raiden-contracts/blob/master/RELEASE.rst and remove the comment when done:

This document has not been tested by someone else than @loredanacirstea.

If anything is wrong or incomplete, a PR should be opened.

pirapira commented 5 years ago

I start this one today.

pirapira commented 5 years ago

@loredanacirstea when I'm deploying the services contracts to Ropsten, what shall I use for TOKEN_USED_TO_PAY_SERVICES?

I'm following https://github.com/raiden-network/raiden-contracts#deployment-on-a-testnet

python -m raiden_contracts.deploy services --rpc-provider http://127.0.0.1:8545 --private-key /path/to/your/private_key/file --gas-price 10 --gas-limit 6000000 --token-address TOKEN_USED_TO_PAY_SERVICES
loredanacirstea commented 5 years ago

@palango - any preference? We can use WETH, considering our token registration limits. Or the CustomToken that we have in our tests.

palango commented 5 years ago

Will the new deployment have limits and be limited to WETH as well? Then WETH makes most sense, otherwise it might be nice to have a mintable token. @karlb Opinions on your side?

Different question: When do you plan to do the deployment? Can we maybe get in the MS and UDC changes?

pirapira commented 5 years ago

Will the new deployment have limits and be limited to WETH as well?

Yes. So I go with WETH.

When do you plan to do the deployment?

This week or the next week latest. The main purpose is that I learn the procedure.

Can we maybe get in the MS and UDC changes?

I don't mind repeating the deploy process.

loredanacirstea commented 5 years ago

I already added the MSC and RSBC to the deployment process in https://github.com/raiden-network/raiden-contracts/pull/449. Once the UDC PR is merged, @karlb can add it.

pirapira commented 5 years ago

I already added the MSC and RSBC

That sounds like an ABI change. Should the next version number be 0.5.0. instead of 0.4.1?

loredanacirstea commented 5 years ago

Yes. After the UDC is added and we are ready for the release.

karlb commented 5 years ago

Will the new deployment have limits and be limited to WETH as well? Then WETH makes most sense, otherwise it might be nice to have a mintable token. @karlb Opinions on your side?

No preferences, WETH seems fine.

pirapira commented 5 years ago

Etherscan verification is failing for me on all three test networks. I'm seeing

{'status': '0', 'message': 'NOTOK', 'result': 'Fail - Unable to verify'}
pirapira commented 5 years ago

but I was able to register the source code manually on Etherscan.

loredanacirstea commented 5 years ago

Yes, it is a known weird issue: https://github.com/raiden-network/raiden-contracts/issues/349.

pirapira commented 5 years ago

I made #459 after bumping the package version.

pirapira commented 5 years ago

This has been done.