search

raiden-network / raiden-monitoring-service

Raiden monitoring service
5 stars 6 forks source link

Adapt raiden comma style #44

Closed palango closed 5 years ago

LefterisJP commented 5 years ago

Guys I would also suggest to have the exact same style/linting tools in all of the projects. As such you can put a linter for the commas (and also for some other issues). In raiden we got: 

flake8==3.6.0
flake8-bugbear==18.8.0
flake8-commas==2.0.0
flake8-tuple==0.2.13
isort==4.2.15

commas will find all of those missing trailing commas, bugbear will find miscellaneous bugs and tuple will find commas that introduce tuples where you don't expect them

karlb commented 5 years ago

@LefterisJP: exactly these lines are part of this PR (only the isort version differs). Maybe we can start moving these parts to a shared place in the monorepo.

LefterisJP commented 5 years ago

@karlb oh my god I am blind. I looked at the diff to see if they were added and could not see them before writting my comment :)

LefterisJP commented 5 years ago

Maybe we can start moving these parts to a shared place in the monorepo.

The monorepo will essentially be the client repo. But if we go with the original plan I guess each subproject needs its own requirements files anyway. Perhaps in the top directory there could be a tool that checks if the 3 subprojects have the same linting requirements -- but perhaps this is also an overkill.