search

raiden-network / raiden-monitoring-service

Raiden monitoring service
5 stars 6 forks source link

Remove StateDBMockup and fix discovered problems #45

Closed karlb closed 5 years ago

karlb commented 5 years ago

The db was neither used manually nor in the tests, so many things were completely broken. Some fixed things:

Also some cleanup on top of this. More refactoring/cleanup of db to come.

codecov-io commented 5 years ago

Codecov Report

Merging #45 into master will increase coverage by 1.6%. The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #45     +/-   ##
=========================================
+ Coverage   52.04%   53.64%   +1.6%     
=========================================
  Files          22       21      -1     
  Lines         661      645     -16     
  Branches       52       53      +1     
=========================================
+ Hits          344      346      +2     
+ Misses        306      287     -19     
- Partials       11       12      +1
Impacted Files Coverage Δ
monitoring_service/state_db/__init__.py 50% <ø> (-16.67%) :arrow_down:
monitoring_service/tasks/on_channel_close.py 100% <100%> (ø) :arrow_up:
monitoring_service/state_db/sqlite_db.py 88.23% <88.23%> (+23.94%) :arrow_up:
monitoring_service/utils/blockchain_listener.py 82.8% <0%> (+0.63%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 30f6b92...d08299c. Read the comment docs.