search

raiden-network / raiden-wizard

The Raiden Wizard On-Boarding Tool
https://raiden-network.readthedocs.io/en/stable/installation/quick-start/
MIT License
9 stars 17 forks source link

Refactor frontend #319

Closed manuelwedler closed 4 years ago

manuelwedler commented 4 years ago

This PR moves all inline javascript to its own js files. This will make the frontend more easily testable and more modular. Additionally it removes the redundancies of the question mark element and changes the frontend to use the DOMContentLoaded event instead of load to start the logic.

codecov[bot] commented 4 years ago

Codecov Report

Merging #319 into develop will decrease coverage by 49.72%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #319       +/-   ##
============================================
- Coverage    89.26%   39.54%   -49.73%     
============================================
  Files           22       18        -4     
  Lines         1761     1573      -188     
============================================
- Hits          1572      622      -950     
- Misses         189      951      +762
Flag Coverage Δ
#python-integration ?
#python-unit 39.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiden_installer/kyber/web3/tokens.py 0.00% <0.00%> (-100.00%) :arrow_down:
raiden_installer/kyber/web3/constants.py 0.00% <0.00%> (-100.00%) :arrow_down:
raiden_installer/kyber/web3/contracts.py 0.00% <0.00%> (-100.00%) :arrow_down:
raiden_installer/uniswap/web3/contracts.py 0.00% <0.00%> (-100.00%) :arrow_down:
raiden_installer/token_exchange.py 0.00% <0.00%> (-97.80%) :arrow_down:
raiden_installer/web_testnet.py 0.00% <0.00%> (-96.67%) :arrow_down:
raiden_installer/shared_handlers.py 0.00% <0.00%> (-95.94%) :arrow_down:
raiden_installer/transactions.py 0.00% <0.00%> (-95.92%) :arrow_down:
raiden_installer/web.py 0.00% <0.00%> (-90.69%) :arrow_down:
raiden_installer/utils.py 36.92% <0.00%> (-55.39%) :arrow_down:
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2a6256...f76f84b. Read the comment docs.