search

raiden-network / scenario-player

MIT License
1 stars 16 forks source link

AssertPFSIOU tasks does unnecessary retries #623

Closed karlb closed 3 years ago

karlb commented 3 years ago

The AssertPFSIOU retries until it reaches its timeout of five minutes, even though the results seem to be correct (the task succeeds)

│   - [✔] Serial 0:16:40.951634 - Check that IOUs exist after the payments                                                                                                                                                                                   
│      - [✔] Wait 0:01:40.000391: 100                                                                                                                                                                                                                        
│      - [✔] AssertPFSHistory 0:00:00.742676: {'source': 3, 'target': 0, 'request_count': 10}                                                                                                                                                                
│      - [✔] AssertPFSIOU 0:05:00.002039: {'source': 3, 'amount': '500000000000000000'}                                                                                                                                                                      
│      - [✔] AssertPFSHistory 0:00:00.182619: {'source': 1, 'target': 4, 'request_count': 10}                                                                                                                                                                
│      - [✔] AssertPFSIOU 0:05:00.004982: {'source': 1, 'amount': '500000000000000000'}                                                                                                                                                                      
│      - [✔] AssertPFSIOU 0:05:00.004574: {'source': 2, 'iou_exists': False}

I observed this in bf1.

palango commented 3 years ago

@karlb Was this on latest master? This should be fixed on https://github.com/raiden-network/scenario-player/commit/de8d91ec9207f588c876b24b28d3769b23245efc#diff-ed33d6580aa331aea1599566ebc17b62b811c1d001e7eb60ff9b6ff29c3432aaR360

karlb commented 3 years ago

I'm not entirely sure. I'll check next time I run it.

karlb commented 3 years ago

I tested it again with the latest version and the last AssertPFSIOU still takes 5 minutes.

│   - [✔] Serial 0:06:41.004447 - Check that IOUs exist after the payments                                                                                                                                                                                   │
│      - [✔] Wait 0:01:40.000667: 100                                                                                                                                                                                                                        │
│      - [✔] AssertPFSHistory 0:00:00.519937: {'source': 3, 'target': 0, 'request_count': 10}                                                                                                                                                                │
│      - [✔] AssertPFSIOU 0:00:00.128907: {'source': 3, 'amount': '500000000000000000'}                                                                                                                                                                      │
│      - [✔] AssertPFSHistory 0:00:00.208234: {'source': 1, 'target': 4, 'request_count': 10}                                                                                                                                                                │
│      - [✔] AssertPFSIOU 0:00:00.132619: {'source': 1, 'amount': '500000000000000000'}                                                                                                                                                                      │
│      - [✔] AssertPFSIOU 0:05:00.001916: {'source': 2, 'iou_exists': False}                                                                                                                                                                                 │

That's not supposed to be the case, is it?

palango commented 3 years ago

No, I'll have a look. Can you please attach the logs of the run here?

karlb commented 3 years ago

The run didn't finish yet, but here is the current log: https://drive.google.com/file/d/1DOZRoUXbS6CVcjXhmSkZCp9CZH69DFZj/view?usp=sharing