search

raiden-network / spec

Spec of the Raiden Network protocol
8 stars 19 forks source link

Add a check for correctness of pull requests #306

Closed jomuel closed 4 years ago

jomuel commented 4 years ago

Currently pull requests to this repo are not built before merging and thus not checked for correctness at all. At least two prs have been merged in the past that introduced trivial errors like wrong indentation, so that the post-merge build on readthedocs.io failed and had to be debugged. It would be more efficient to catch such errors in advance.

palango commented 4 years ago

Should be fixed with https://github.com/raiden-network/spec/pull/316

karlb commented 4 years ago

We finally got https://blog.readthedocs.com/building-docs-for-pull-requests/ enabled for this repo:

I have enabled the feature for your project. Make sure that the GitHub webhook has the pull_request event enabled. Let us know if you have any feedback from the feature.

I'll give it a try when I next work on the spec.